[6/N] Add update in module #11533
Open
[6/N] Add update in module #11533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose the update API in module. Inside the module. invoke the method. Update API - Did a bit refactor for the `StubBackend` test code, such that it can shared between `backend_interface_update_test.cpp` and `module_test.cpp` Differential Revision: [D76172680](https://our.internmc.facebook.com/intern/diff/D76172680/) [ghstack-poisoned]
cccclai
requested review from
larryliu0820,
kirklandsign,
JacobSzwejbka,
lucylq,
swolchok and
shoumikhin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11533
Note: Links to docs will display an error until the docs builds have been completed. ❌ 27 New Failures, 2 Unrelated FailuresAs of commit f0c47a6 with merge base f7cc72f ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 10, 2025
This PR needs a
|
|
This pull request was exported from Phabricator. Differential Revision: D76172680 |
- Expose the update API in module. Inside the module. invoke the method. Update API - Did a bit refactor for the `StubBackend` test code, such that it can shared between `backend_interface_update_test.cpp` and `module_test.cpp` Differential Revision: [D76172680](https://our.internmc.facebook.com/intern/diff/D76172680/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76172680 |
kimishpatel
reviewed
Jun 13, 2025
Comment on lines
+312
to
+319
| runtime::Error Module::update( | ||
| const std::string& method_name, | ||
| runtime::ArrayRef<runtime::Entry> backend_options) { | ||
| ET_CHECK_OK_OR_RETURN_ERROR(load_method(method_name)); | ||
| auto& method = methods_.at(method_name).method; | ||
| return method->update(backend_options); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is exactly my problem. none of the piping being done here is module or method name specific. Because the options being sent down are to the global singleton of backend. It would make sense only if we have a way to set options on an instance of the backend class that is tied to a given method and model.
Also I apologize if this was already discussed in review. It has been a while so likely I forgot
There was a problem hiding this comment.
I think we want to provide backend flexibility to decide whether it's global or per session. There is one single instance of the backend class. It is a singleton and processes all the .pte files (including all methods) even from different processes. We want the backend to have the option as needed.
Additionally, currently users don't interact with backend directly, Users just load the .pte file, construct the method. ET runtime is responsible for passing the information between user and the backends.
- Expose the update API in module. Inside the module. invoke the method. Update API - Did a bit refactor for the `StubBackend` test code, such that it can shared between `backend_interface_update_test.cpp` and `module_test.cpp` Differential Revision: [D76172680](https://our.internmc.facebook.com/intern/diff/D76172680/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76172680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
StubBackendtest code, such that it can shared betweenbackend_interface_update_test.cppandmodule_test.cppDifferential Revision: D76172680