-
Notifications
You must be signed in to change notification settings - Fork 593
[4/N] Add backend options map #11462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/cccclai/24/base
Are you sure you want to change the base?
Conversation
This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11462
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Unrelated FailuresAs of commit cab5519 with merge base f7cc72f ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This pull request was exported from Phabricator. Differential Revision: D76149466 |
This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D76149466 |
This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D76149466 |
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whats happening in these diffs and why they show up as so many deleted lines and so many added lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it's the weird formatting. Let me update so it's easier to review. I've been manually running lintrunner to get rid of the weird formating
return executorch::runtime::ArrayRef<BackendOption>(options_, size_); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this method needed?
}; | ||
|
||
template <size_t MaxBackends> | ||
class BackendOptionsMap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this?
Stack from ghstack (oldest at bottom):
This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend.
Differential Revision: D76149466