-
Notifications
You must be signed in to change notification settings - Fork 590
[1/N] Add BackendOptions class #11389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/cccclai/21/base
Are you sure you want to change the base?
Conversation
Introduce backend option as discussed in #10216 Step 1: Introducd Backend Option class In later stage, it will be plugged in with the rest of the stack. Differential Revision: [D75993712](https://our.internmc.facebook.com/intern/diff/D75993712/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11389
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ee878bd with merge base ef1d2ff ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Introduce backend option as discussed in #10216 Step 1: Introducd Backend Option class In later stage, it will be plugged in with the rest of the stack. Differential Revision: [D75993712](https://our.internmc.facebook.com/intern/diff/D75993712/) ghstack-source-id: 288273758 Pull Request resolved: #11389
This pull request was exported from Phabricator. Differential Revision: D75993712 |
This PR needs a
|
Previous comment in the old PR: #11288 From @JacobSzwejbka :
|
From @mergennachin:
|
My response:
|
I think what @mergennachin suggested makes sense. If user code is setting backend specific option they already have to know what backend they are talking about, unless some options are backend agnostic. Other piece of the puzzle is how the user will update this. And from #10216 it seems that we will pipe |
Introduce backend option as discussed in #10216 Step 1: Introducd Backend Option class In later stage, it will be plugged in with the rest of the stack. Differential Revision: [D75993712](https://our.internmc.facebook.com/intern/diff/D75993712/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D75993712 |
Introduce backend option as discussed in #10216 Step 1: Introducd Backend Option class In later stage, it will be plugged in with the rest of the stack. Differential Revision: [D75993712](https://our.internmc.facebook.com/intern/diff/D75993712/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D75993712 |
Stack from ghstack (oldest at bottom):
Introduce backend option as discussed in #10216
Step 1: Introducd Backend Option class
In later stage, it will be plugged in with the rest of the stack.
Differential Revision: D75993712