Make setup.py py3 compatible.

[jaitaiwan]

I've done a basic update to the library to begin getting it to be python3 compatible. A lot of upstream projects still rely on this unfortunately and their communities are not willing to change to oauthlib. This will help to prolong the inevitable. This should begin to partially relieve #147

[jaitaiwan]

By my testing, these are all the commits necessary for installing (at the very least) on python 3 and the install appears to work in python2.7 still. I'll add any additional commits in a separate pull request if using the lib fails for other reasons. This means that unless the author has their objections, this pull should be ready.

[simplemind93]

Hello jaitaiwan, Thanks for oauth2 making work with python3. This may be a stupid question but how do I download the comitted version of the setup.py? thanks for the answer

[jaitaiwan]

If you're using pip, just go to my forked version of the repository and
copy the link to the zip. Then you just run pip install --upgrade zipfile

On Thu, Jul 3, 2014 at 1:07 AM, Pranav [email protected] wrote:

Hello jaitaiwan, Thanks for oauth2 making work with python3. This may be a
stupid question but how do I download the comitted version of the setup.py?
thanks for the answer

—
Reply to this email directly or view it on GitHub
#158 (comment)
.

[granda]

Any update on when this can be merged? Any reason why it cannot be?

#147 (comment) did resolve it but it's tedious to do every time.

[jaitaiwan]

@granda without updates from the original author, it might be time to use the forked version.

[jirutka]

+1

[instantepiphany]

Please merge this +1

[kilotaras]

bump

[jaitaiwan]

I'd just use python social auth. Once you learn how to navigate the
documents then its easier to put it together. Plus the maintainer is super
friendly and helpful.

Kind Regards,

Daniel J Holmes

On Thu, Nov 27, 2014 at 9:01 PM, Taras Boiko [email protected]
wrote:

bump

—
Reply to this email directly or view it on GitHub
#158 (comment)
.

[hayd]

@granda without updates from the original author, it might be time to use the forked version.

This project has not been updated in three years.

see also #142.

[coilysiren]

ugh :/

[hayd]

I think the correct library to use is oauthlib: https://oauthlib.readthedocs.org/en/latest/index.html

There should REALLY be a banner at the top of "python-oauth2"'s readme to say a. no longer worked on/supported/PRs not accepted/read b. only for oauth1 (???!). It's a shame that google sends to this repo.

Confusingly another similar project is named https://github.com/wndhydrnt/python-oauth2 !

[jaitaiwan]

If someone creates a pull request to do a banner then that might be
accepted and help to fix the issue.

On Fri, 12 Jun 2015 at 15:14 Andy Hayden [email protected] wrote:

I think the correct library to use is oauthlib:
https://oauthlib.readthedocs.org/en/latest/index.html

There should REALLY be a banner at the top of "python-oauth2"'s readme to
say a. no longer worked on/supported/PRs not accepted/read b. only for
oauth1 (???!). It's a shame that google sends to this repo.

—
Reply to this email directly or view it on GitHub
#158 (comment)
.

[hayd]

Maybe it'll help to ping @urbanairship (who acquired simplegeo in 2011) or someone there (not sure if github mentions ping the whole team), perhaps someone in the company still has repo access...

I wouldn't hold your breath! Edit: I am holding my breath!

[jaitaiwan]

Hey @aalpern I thought I'd tag you here considering you're one of the most active from @urbanairship and you happened to be first on the list. Any chance you can help us to resolve some of the PR's on this repo?

[aalpern]

Wow - I had no idea this even existed :) I don't have write access to the repository - I can poke around and see if anyone still here does.

[hayd]

pypi author/maintainer is @joestump, so if such a banner/message were to be pushed to pypi it would need him to do it? (or edit something in.)

[joestump]

Let me know and I can transfer ownership of the repo and of the PyPi package. Who's best to pick up the mantle?

[markunsworth]

I'd be happy to pick up the mantle on this one.

[joestump]

It appears I'm not an admin of this repo anymore. I'm tracking that down at @urbanairship. In the meantime, can @jaitaiwan and @markunsworth get me PyPi usernames so I can bless you two to push new packages?

[markunsworth]

@joestump - my pypi username is markunsworth

[joestump]

@markunsworth I added you as a maintainer.

[jaitaiwan]

Hi @joestump, mine is jaitaiwan as well

[joestump]

@jaitaiwan I just added you as a PyPi maintainer as well. 👍

[jaitaiwan]

Cheers!

[markunsworth]

thanks joe

[markunsworth]

@joestump did you get anywhere tracking down an admin/owner of this library?

[jaitaiwan]

@markunsworth perhaps we could start by providing a new update to PyPi from a new forked repo? Eventually people will start finding it just from PyPi yeh?

[jaitaiwan]

I've just created an obnoxious issue as you can see above to ward off people from creating issues/using this repo for now until we get some responses back. I'm not sure but there may be a way @github could help by allowing someone from urbanairship or even @joestump to take over the repo again.

[joestump]

I just pinged my contact at @urbanairship to see if I can get anywhere.

[xamiax]

Any chance on including the option to set a custom grant_type into the future base library?
So it would be usable for a wider range of usage.

[jaitaiwan]

@xamiax when we determine the official fork, you can do an feature request there. @markunsworth @joestump do you guys have a fork you'd like to use, or did you want to use the one I've got CentricWebEstate/python-oauth2 ? I can add you both as contributors.

[joestump]

I've got the repository transferred into my account. Should we go through the PRs and issues here to keep things canonical here? (Also, who would like to be added as contributors?)

[jaitaiwan]

Awesome. @joestump sounds good. I'm happy to become a contributor.

[joestump]

@jaitaiwan be careful what you wish for! You've been added. I've merged in a few PRs and have CI configured (though Travis has yet to actually build it yet for some reason).

[jaitaiwan]

@joestump Travis is generally horrible for building stuff. They have outages every other days because of build failures and delays. I'd personally recommend SemaphoreCI (its free for open source). Also codeship is open source too.

[jaitaiwan]

Is this PR good to merge? I can't see any integration showing its passing tests?

[joestump]

Looks fine to me. Travis isn't running builds on this for whatever reason; I've pinged them on Twitter. If tests pass locally, I say merge. 👍

[jaitaiwan]

@joestump keen on implementing a majority vote for merges similar to Docker's LGTM?

[joestump]

@jaitaiwan Well, given we're 2/2 I think we have that. 😆 If anyone else wants to join, I'm all about a majority vote.

[hayd]

@joestump Thanks for pushing this through, great work!

Travis appears to be building now, but I'm not sure there's a way to trigger old branches/PRs. :(

[joestump]

@hayd Sadly, you have to re-push to kick off another build. I'm sure @jaitaiwan will be re-merging with master and pushing soon. In the meantime, I've addressed quite a few bugs and done an audit of all of the PRs. If anyone sees a "Needs Tests" PR and wants to help out, that'd be great. 😂

[jaitaiwan]

@joestump just trolling through all 57 of your updates 👍 brb

[jaitaiwan]

This one got closed automatically as I was fixing all the heads etc on my branches. New PR is here: #176

[xamiax]

So is this library maintained again? If so, where could I request a feature?

[jaitaiwan]

@xamiax yup! We finally got access to it after years of it being unmaintained. Just open an issue and we'll take a look 👍