preliminary python 3 porting work (most tests pass) #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe #158 closes this out. @jaitaiwan can you confirm? |
|
@benthor really appreciate the effort but I think we have 2 or 3 PR's which have a more fleshed out implementation. I think perhaps even my PR is not even as feature-full as others out there. So I'm going to close this one in favour of #158 and the others we've shortlisted there. Again thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might serve as basis for a serious effort. some tests were disabled due to the fact that python3 doesn't have meaningful byte literals inside strings any more.