Tweaks: (enhancement) Add min module count setting to Case Generator #61
Conversation
| // Make sure a size is found even if the user threshold is enormous (above 2 * componentCount^2 - 1) | ||
| int caseSizeSearchLimit = System.Math.Max(componentCount, Tweaks.userSettings.CaseGeneratorMinModules + 1); | ||
|
|
||
| List<Vector2> caseSizes = new List<Vector2>(); | ||
| for (int x = 1; x <= componentCount; x++) | ||
| for (int y = 1; y <= componentCount; y++) | ||
| for (int x = 1; x <= caseSizeSearchLimit; x++) | ||
| for (int y = 1; y <= caseSizeSearchLimit; y++) |
There was a problem hiding this comment.
I don't understand why this change is needed. Why would we need to generate cases that are bigger than the maximum needed for the bomb?
There was a problem hiding this comment.
This particular change prevents a potential edge case issue... sort of:
There is a hidden assumption that the case generator always generates a valid case to be used, but if for whatever reason the user sets the minimum module threshold to be ridiculously and unpractically high (which.. why would they, but they might) then all potential cases sizes would be filtered out, breaking that assumption.
Concrete example: about 340 minimum with only 12 modules in a mission and no other modded cases installed will result in no valid cases, despite case generator being enabled.
But a lot of the time componentCount will be higher than the threshold anyway, so this does not impede performance, just handles the edge case.
There was a problem hiding this comment.
So.. should this be marked resolved or.. should I revert this change?
With Reasonable Conclusion cases it is possible to disable smaller ones (e.g. 2x2 and 3x3) if the user prefers the vanilla bomb case or the Double Decker. This is not possible to do with the cases generated by Tweaks.
This PR adds a setting that discards cases under a user-defined threshold, allowing better case picker to choose non-generated cases for smaller bombs, if the user wants that.