refactor(mut_reference): replace match with if-let to reduce nesting
#14890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
y21
approved these changes
May 26, 2025
so also squash all the commit messages? or reword the resulting commit to match the PR description? |
|
Yeah, you could reword the commit message to the title of this PR, that sounds good |
ada4a
force-pushed
the
refactor-mut_reference
branch
from
d7b7f9b to
c256bcc
Compare
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One downside to this is that, since the patterns matched against (on the left) are quite long, it's a bit difficult to see what's even getting matched. Using
matches!()could help with thatchangelog: none