[non_canonical_partial_ord_impl]: Fix emitting warnings which conflict with needless_return
#12702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
Manishearth
reviewed
Apr 23, 2024
| kind: ExprKind::Ret(Some(Expr { kind: ret_kind, .. })), | ||
| .. | ||
| }) = stmt.kind | ||
| && let ExprKind::Call( |
There was a problem hiding this comment.
can this code and the previous code be shared somehow? perhaps a factored out "expr_is_cmp" or something
…ict with `needless_return`
Luv-Ray
force-pushed
the
non_canonical_partial_ord_impl
branch
from
6784c22 to
107e44b
Compare
Manishearth
approved these changes
Apr 24, 2024
|
@bors r+ thanks!! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12683
changelog: fix [
non_canonical_partial_ord_impl] emitting warnings which conflict withneedless_return