Skip to content

fix: Typo mistake in CI #19920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: Typo mistake in CI #19920

merged 1 commit into from
Jun 4, 2025

Conversation

ShoyuVanilla
Copy link
Member

Sorry for consecutive mistakes in PRs 😢

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2025
@ShoyuVanilla ShoyuVanilla changed the title fix: Remove typo in CI fix: Typo mistake in CI Jun 4, 2025
@lnicola
Copy link
Member

lnicola commented Jun 4, 2025

Can you switch to the version in publish-libs.yaml instead, so we don't have two different ways of doing the same thing? It's also easier to read.

@ShoyuVanilla
Copy link
Member Author

Can you switch to the version in publish-libs.yaml instead, so we don't have two different ways of doing the same thing?

Okay, that would be better

@lnicola
Copy link
Member

lnicola commented Jun 4, 2025

Oh, wow..

@lnicola lnicola disabled auto-merge June 4, 2025 06:25
@lnicola lnicola enabled auto-merge June 4, 2025 06:25
@ShoyuVanilla
Copy link
Member Author

         FAIL [  21.334s] rust-analyzer::slow-tests diagnostics_dont_block_typing
  stdout ───

    running 1 test
    test diagnostics_dont_block_typing ... FAILED

    failures:

    failures:
        diagnostics_dont_block_typing

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 35 filtered out; finished in 21.32s

  stderr ───

    thread 'diagnostics_dont_block_typing' panicked at crates/rust-analyzer/tests/slow-tests/main.rs:938:5:
    typing enter took 5.538838333s
    stack backtrace:
       0: __rustc::rust_begin_unwind
                 at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/panicking.rs:697:5
       1: core::panicking::panic_fmt
                 at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/panicking.rs:75:14
       2: slow_tests::diagnostics_dont_block_typing
                 at ./tests/slow-tests/main.rs:938:5
       3: slow_tests::diagnostics_dont_block_typing::{{closure}}
                 at ./tests/slow-tests/main.rs:882:35
       4: core::ops::function::FnOnce::call_once
                 at /Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
       5: core::ops::function::FnOnce::call_once
                 at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/ops/function.rs:250:5
    note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

────────────
     Summary [  68.188s] 7011 tests run: 7010 passed, 1 failed, 6 skipped
        FAIL [  21.334s] rust-analyzer::slow-tests diagnostics_dont_block_typing
error: test run failed

Another random failure on our tests. Might worth investigation 😂

@lnicola lnicola added this pull request to the merge queue Jun 4, 2025
Merged via the queue into rust-lang:master with commit 134889e Jun 4, 2025
24 of 28 checks passed
@lnicola
Copy link
Member

lnicola commented Jun 4, 2025

This did nothing: https://github.com/rust-lang/rust-analyzer/actions/runs/15435524662/job/43441075014 🥲

@ShoyuVanilla
Copy link
Member Author

So, xtask wasn't the problem and cargo-workspaces's scheduling logic might be the cause of the regression, as my initial assumption. I'll retry that 😅

@ShoyuVanilla ShoyuVanilla deleted the patch-2 branch June 4, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants