-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ci: When autopublishing, remove xtask
from workspace
#19919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we also revert the other change, then? |
Yes, I think that's reasonable |
.github/workflows/autopublish.yaml
Outdated
# Remove library crates from the workspaces so we don't auto-publish them as well | ||
sed -i 's/ "lib\/\*",//' ./Cargo.toml | ||
# Remove library crates and xtask from the workspaces so we don't auto-publish them as well | ||
sed -i 's/ "lib\/\*",//; s/ "xtask\/",//' ./Cargo.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to do it this way because there's no space before xtask
. The order doesn't matter though.
sed -i 's/ "lib\/\*",//; s/ "xtask\/",//' ./Cargo.toml | |
sed -i 's/"xtask\\/",//; s/ "lib\/\*",//' ./Cargo.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch!
Revert `cargo-workspaces` version fix
|
# Only publish the crates under lib/
sed -i 's|^members = .*$|members = ["lib/*"]|' Cargo.toml I was sure I made this change before, that's why. |
I see now that EDIT: no, not missing, an extra one. |
Yes, that seems better.
|
Opened #19920 😅 |
c.c #19903