-
Notifications
You must be signed in to change notification settings - Fork 386
feat: multiple output images; replace http polling with websocket to check when a workflow is done #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
…yui into feat/refactor
…shot" with a simplified, custom docker image BREAKING CHANGE
BREAKING CHANGE: api output is not compatible anymore
TimPietrusky
pushed a commit
that referenced
this pull request
May 2, 2025
# [5.0.0](4.0.1...5.0.0) (2025-05-02) ### Features * multiple output images; replace http polling with websocket to check when a workflow is done ([#118](#118)) ([b14068f](b14068f)) ### BREAKING CHANGES * api output is not compatible anymore * docs: added all possible comfyui folders; simplified guide of method 1 * fix(model): flux.1-schnell is gated * feat: update to 0.3.30 * test: don't run "snapshot_restoration" tests * chore: force local images * docs: lowercase for code comments * ci: run release for changes in "main" * fix: workflow trigger * ci: build only base for now
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
< 5.0.0
returned the primary image data (S3 URL or base64 string) directly within anoutput.message
fieldv5.0.0
, the output format has changed significantly:output.images
fieldfilename
: The original filename from ComfyUItype
: Either"s3_url"
or"base64"
data
: The corresponding S3 URL or the base64 encoded image stringFeatures
Websocket Communication: Replaced HTTP polling with websockets for job status monitoring and completion.
Multiple Output Images: Processes and returns all non-
temp
images from the workflow historySimplified Customization Workflow: Users no longer need to fork the repository & use the "snapshot restoration" workflow to add custom nodes or models. They can create their own
Dockerfile
that buildsFROM
an official base image, usingcomfy-cli
for setup to install custom-nodes and download modelsComfyUI update: 0.3.30
Direct Image Retrieval: Fetches image data via ComfyUI
/view
API instead of filesystem accessFilename in Output: Includes original
filename
in the output data for each imageWebsocket Reconnection: Added automatic reconnection attempts for dropped connections during monitoring
Unhandled Output Warnings: Logs warnings for unrecognized node output types
Removed Redundant Output: Removed the
refresh_worker
key fromhandler.py
return values, as the behavior is solely controlled by the environment variableDocumentation
README.md
into a concise overview and quickstart guide, moving detailed sections (deployment, configuration, customization, development, ci/cd, acknowledgments) into separate, focused files within thedocs/
directory for improved readability and maintainabilitydocs/customization.md
to feature the new, simpler method using a customDockerfile
withcomfy-cli
commands (comfy node install
,comfy model download
). Removed the old method requiring repository forks and snapshotsBug Fixes
data:[...];base64,...
prefixes in input image strings.