Skip to content

[BUG]: Pulid2 Custom Nodes Import Failed #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ardha27 opened this issue Feb 21, 2025 · 4 comments · Fixed by #118
Closed

[BUG]: Pulid2 Custom Nodes Import Failed #97

ardha27 opened this issue Feb 21, 2025 · 4 comments · Fixed by #118
Assignees
@TimPietrusky
Labels
bug Something isn't working released

Comments

@ardha27
Copy link

ardha27 commented Feb 21, 2025 •
edited
Loading

Describe the bug

i know, it could be my mistake on how i install the custom nodes, but i hope you can help me with this. Thank you

Total VRAM 45515 MB, total RAM 515599 MB
pytorch version: 2.6.0+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA A40 : cudaMallocAsync
�[36;20m[comfyui_controlnet_aux] | INFO -> Using ckpts path: /comfyui/custom_nodes/comfyui_controlnet_aux/ckpts�[0m
�[36;20m[comfyui_controlnet_aux] | INFO -> Using symlinks: False�[0m
�[36;20m[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']�[0m
/comfyui/custom_nodes/comfyui_controlnet_aux/node_wrappers/dwpose.py:26: UserWarning: DWPose: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device. DWPose might run very slowly
  warnings.warn("DWPose: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device. DWPose might run very slowly")
Traceback (most recent call last):
  File "/comfyui/nodes.py", line 2112, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/comfyui/custom_nodes/comfyui_pulid_flux_ll/__init__.py", line 1, in <module>
    from .pulidflux import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
  File "/comfyui/custom_nodes/comfyui_pulid_flux_ll/pulidflux.py", line 6, in <module>
    from insightface.utils.download import download_file
ImportError: cannot import name 'download_file' from 'insightface.utils.download' (/usr/local/lib/python3.10/dist-packages/insightface/utils/download.py)
Cannot import /comfyui/custom_nodes/comfyui_pulid_flux_ll module for custom nodes: cannot import name 'download_file' from 'insightface.utils.download' (/usr/local/lib/python3.10/dist-packages/insightface/utils/download.py)
Import times for custom nodes:
   0.0 seconds: /comfyui/custom_nodes/websocket_image_save.py
   0.0 seconds: /comfyui/custom_nodes/comfyui_patches_ll
   0.0 seconds (IMPORT FAILED): /comfyui/custom_nodes/comfyui_pulid_flux_ll

Repro MVP (Minimal Viable Procedure)

i'm using this snapshot to install the custom_nodes

{
    "comfyui": "31e54b7052bd65c151018950bd95473e3f9a9489",
    "git_custom_nodes": {
        "https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes": {
            "hash": "d78b780ae43fcf8c6b7c6505e6ffb4584281ceca",
            "disabled": false
        },
        "https://github.com/Fannovel16/comfyui_controlnet_aux": {
            "hash": "1e9eac6377c882da8bb360c7544607036904362c",
            "disabled": false
        },
        "https://github.com/ltdrdata/ComfyUI-Manager": {
            "hash": "c63b2127007382ffef1144365b9d5182838fb792",
            "disabled": false
        }
    },
    "cnr_custom_nodes": {
        "comfyui-kjnodes": "1.0.5",
        "comfyui-florence2": "1.0.3",
        "comfyui_pulid_flux_ll": "1.1.4",
        "comfyui_patches_ll": "1.0.6"
    },
    "file_custom_nodes": [
        {
            "filename": "websocket_image_save.py",
            "disabled": false
        }
    ],
    "pips": {
        "accelerate==1.4.0": "",
        "aiohappyeyeballs==2.4.0": "",
        "aiohttp==3.10.6": "",
        "aiosignal==1.3.1": "",
        "albucore==0.0.17": "",
        "albumentations==1.4.16": "",
        "annotated-types==0.7.0": "",
        "anyio==4.6.0": "",
        "arrow==1.3.0": "",
        "asttokens==2.4.1": "",
        "async-timeout==4.0.3": "",
        "attrs==24.2.0": "",
        "beautifulsoup4==4.12.3": "",
        "binaryornot==0.4.4": "",
        "certifi==2024.8.30": "",
        "cffi==1.17.1": "",
        "chardet==5.2.0": "",
        "charset-normalizer==3.3.2": "",
        "click==8.1.7": "",
        "clip-interrogator==0.6.0": "",
        "color-matcher==0.5.0": "",
        "coloredlogs==15.0.1": "",
        "colour-science==0.4.4": "",
        "comm==0.2.2": "",
        "contourpy==1.3.1": "",
        "cookiecutter==2.6.0": "",
        "cryptography==43.0.1": "",
        "cycler==0.12.1": "",
        "Cython==3.0.12": "",
        "ddt==1.7.2": "",
        "debugpy==1.8.6": "",
        "decorator==5.1.1": "",
        "Deprecated==1.2.14": "",
        "diffusers==0.27.2": "",
        "distro==1.9.0": "",
        "docutils==0.21.2": "",
        "easydict==1.13": "",
        "einops==0.8.0": "",
        "eval_type_backport==0.2.0": "",
        "exceptiongroup==1.2.2": "",
        "executing==2.1.0": "",
        "facexlib==0.3.0": "",
        "fal_client==0.5.9": "",
        "fastapi==0.115.0": "",
        "filelock==3.13.1": "",
        "filterpy==1.4.5": "",
        "flatbuffers==24.3.25": "",
        "flet==0.24.1": "",
        "flet-core==0.24.1": "",
        "flet-runtime==0.24.1": "",
        "fonttools==4.56.0": "",
        "frozenlist==1.4.1": "",
        "fsspec==2024.2.0": "",
        "ftfy==6.3.1": "",
        "gdown==5.2.0": "",
        "gitdb==4.0.11": "",
        "GitPython==3.1.43": "",
        "h11==0.14.0": "",
        "httpcore==1.0.5": "",
        "httptools==0.6.1": "",
        "httpx==0.27.2": "",
        "httpx-sse==0.4.0": "",
        "huggingface-hub==0.25.1": "",
        "humanfriendly==10.0": "",
        "idna==3.10": "",
        "imageio==2.35.1": "",
        "importlib_metadata==8.6.1": "",
        "insightface==0.7.3": "",
        "ipykernel==6.29.5": "",
        "ipython==8.27.0": "",
        "ipywidgets==8.1.5": "",
        "jedi==0.19.1": "",
        "Jinja2==3.1.3": "",
        "jiter==0.8.2": "",
        "joblib==1.4.2": "",
        "jsonschema==4.23.0": "",
        "jsonschema-specifications==2023.12.1": "",
        "jupyter_client==8.6.3": "",
        "jupyter_core==5.7.2": "",
        "jupyterlab_widgets==3.0.13": "",
        "kiwisolver==1.4.8": "",
        "kornia==0.7.3": "",
        "kornia_rs==0.1.5": "",
        "lark==1.2.2": "",
        "lazy_loader==0.4": "",
        "llvmlite==0.43.0": "",
        "markdown-it-py==3.0.0": "",
        "MarkupSafe==2.1.5": "",
        "matplotlib==3.10.0": "",
        "matplotlib-inline==0.1.7": "",
        "matrix-client==0.4.0": "",
        "mdurl==0.1.2": "",
        "mpmath==1.3.0": "",
        "mss==10.0.0": "",
        "multidict==6.1.0": "",
        "nest-asyncio==1.6.0": "",
        "networkx==3.2.1": "",
        "numba==0.60.0": "",
        "numpy==1.26.3": "",
        "nvidia-cublas-cu12==12.1.3.1": "",
        "nvidia-cuda-cupti-cu12==12.1.105": "",
        "nvidia-cuda-nvrtc-cu12==12.1.105": "",
        "nvidia-cuda-runtime-cu12==12.1.105": "",
        "nvidia-cudnn-cu12==9.1.0.70": "",
        "nvidia-cufft-cu12==11.0.2.54": "",
        "nvidia-curand-cu12==10.3.2.106": "",
        "nvidia-cusolver-cu12==11.4.5.107": "",
        "nvidia-cusparse-cu12==12.1.0.106": "",
        "nvidia-nccl-cu12==2.20.5": "",
        "nvidia-nvjitlink-cu12==12.1.105": "",
        "nvidia-nvtx-cu12==12.1.105": "",
        "oauthlib==3.2.2": "",
        "onnx==1.17.0": "",
        "onnxruntime==1.19.2": "",
        "onnxruntime-gpu==1.20.1": "",
        "open_clip_torch==2.30.0": "",
        "openai==1.63.2": "",
        "opencv-python==4.10.0.84": "",
        "opencv-python-headless==4.10.0.84": "",
        "packaging==23.2": "",
        "parso==0.8.4": "",
        "peft==0.14.0": "",
        "pexpect==4.9.0": "",
        "pillow==11.1.0": "",
        "pixeloe==0.0.10": "",
        "platformdirs==4.3.6": "",
        "pooch==1.8.2": "",
        "prettytable==3.14.0": "",
        "prompt_toolkit==3.0.48": "",
        "protobuf==5.28.2": "",
        "psutil==6.0.0": "",
        "ptyprocess==0.7.0": "",
        "pure_eval==0.2.3": "",
        "pycparser==2.22": "",
        "pydantic==2.9.2": "",
        "pydantic_core==2.23.4": "",
        "PyGithub==2.4.0": "",
        "Pygments==2.18.0": "",
        "PyJWT==2.9.0": "",
        "PyMatting==1.1.12": "",
        "PyNaCl==1.5.0": "",
        "pyOpenSSL==25.0.0": "",
        "pyparsing==3.2.1": "",
        "pypng==0.20220715.0": "",
        "PySocks==1.7.1": "",
        "python-dateutil==2.9.0.post0": "",
        "python-dotenv==1.0.1": "",
        "python-slugify==8.0.4": "",
        "PyYAML==6.0.2": "",
        "pyzmq==26.2.0": "",
        "qrcode==7.4.2": "",
        "referencing==0.35.1": "",
        "regex==2024.9.11": "",
        "rembg==2.0.59": "",
        "repath==0.9.0": "",
        "requests==2.32.3": "",
        "rich==13.8.1": "",
        "rpds-py==0.20.0": "",
        "safetensors==0.4.5": "",
        "scikit-image==0.24.0": "",
        "scikit-learn==1.6.1": "",
        "scipy==1.14.1": "",
        "sentencepiece==0.2.0": "",
        "shellingham==1.5.4": "",
        "six==1.16.0": "",
        "smmap==5.0.1": "",
        "sniffio==1.3.1": "",
        "soundfile==0.12.1": "",
        "soupsieve==2.6": "",
        "spandrel==0.4.0": "",
        "stack-data==0.6.3": "",
        "starlette==0.38.6": "",
        "sympy==1.12": "",
        "text-unidecode==1.3": "",
        "threadpoolctl==3.5.0": "",
        "tifffile==2024.9.20": "",
        "timm==1.0.9": "",
        "tokenizers==0.20.0": "",
        "toml==0.10.2": "",
        "torch==2.4.1+cu121": "",
        "torchaudio==2.4.1+cu121": "",
        "torchsde==0.2.6": "",
        "torchvision==0.19.1+cu121": "",
        "tornado==6.4.1": "",
        "tqdm==4.66.5": "",
        "traitlets==5.14.3": "",
        "trampoline==0.1.2": "",
        "transformers==4.45.0": "",
        "transparent-background==1.3.2": "",
        "triton==3.0.0": "",
        "typer==0.12.5": "",
        "types-python-dateutil==2.9.0.20240906": "",
        "typing_extensions==4.12.2": "",
        "urllib3==1.26.20": "",
        "uv==0.6.2": "",
        "uvicorn==0.30.6": "",
        "uvloop==0.20.0": "",
        "watchdog==4.0.2": "",
        "watchfiles==0.24.0": "",
        "wcwidth==0.2.13": "",
        "websockets==13.1": "",
        "wget==3.2": "",
        "widgetsnbextension==4.0.13": "",
        "wrapt==1.16.0": "",
        "xformers==0.0.28.post1": "",
        "yarl==1.12.1": "",
        "zipp==3.21.0": ""
    }
}

Expected behavior

Theres should be insightface modules/folder inside pulid2 custom nodes

Screenshots

Image

Versions (please complete the following information):

  • Docker version: 27.3.1
  • ComfyUI version: 0.3.14
  • Host OS: Ubuntu 22.04

Additional context
@ardha27 ardha27 added the bug Something isn't working label Feb 21, 2025
@VictorDumitru
Copy link

Hi @ardha27 , did you manage to work around this? does using network storage + adding the .pth file there fix the issue ?

@TimPietrusky TimPietrusky self-assigned this Apr 28, 2025
@TimPietrusky
Copy link
Member

@ardha27 @VictorDumitru we are changing the way on how to add customNodes, see #118

@TimPietrusky TimPietrusky mentioned this issue May 2, 2025
Merged
@TimPietrusky
Copy link
Member

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vectris-dev
Copy link

vectris-dev commented May 16, 2025 •
edited
Loading

I'm on version 5.0.0 and still having this issue, insightface

When I deploy this dockerfile

FROM runpod/worker-comfyui:5.0.0-sdxl

RUN pip install insightface==0.7.3

WORKDIR /comfyui/custom_nodes

RUN git clone https://github.com/shiimizu/ComfyUI-PhotoMaker-Plus.git

WORKDIR /

RUN mkdir -p /comfyui/models/photomaker && \
    wget -q -O /comfyui/models/photomaker/photomaker-v1.bin https://huggingface.co/TencentARC/PhotoMaker/resolve/main/photomaker-v1.bin && \
    wget -q -O /comfyui/models/photomaker/photomaker-v2.bin https://huggingface.co/TencentARC/PhotoMaker-V2/resolve/main/photomaker-v2.bin

COPY input/ /comfyui/input/

I get this error

Traceback (most recent call last):
  File "/comfyui/nodes.py", line 2128, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/comfyui/custom_nodes/ComfyUI-PhotoMaker-Plus/__init__.py", line 1, in <module>
    from .photomaker import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
  File "/comfyui/custom_nodes/ComfyUI-PhotoMaker-Plus/photomaker.py", line 19, in <module>
    from .insightface_package import analyze_faces, insightface_loader
  File "/comfyui/custom_nodes/ComfyUI-PhotoMaker-Plus/insightface_package.py", line 3, in <module>
    from insightface.app import FaceAnalysis
ModuleNotFoundError: No module named 'insightface'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimPietrusky TimPietrusky

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
4 participants
@TimPietrusky @vectris-dev @ardha27 @VictorDumitru