-
Notifications
You must be signed in to change notification settings - Fork 5
chore: include generated assets in repo #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
emosbaugh
merged 13 commits into
main
from
emosbaugh/sc-124145/build-and-include-web-in-ci-prod-release
May 28, 2025
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3122c56
chore: include dist assets in repo
emosbaugh a1f984c
chore: include generated assets in repo
emosbaugh 3155f43
f
emosbaugh 64367ae
f
emosbaugh d2d756a
f
emosbaugh 196d909
f
emosbaugh d7cef89
f
emosbaugh 92a02e6
f
emosbaugh 7916316
f
emosbaugh d62c0ac
f
emosbaugh d9829a8
f
emosbaugh e8c67ee
Update .nvmrc
emosbaugh 171b990
f
emosbaugh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
SHELL := /bin/bash | ||
|
||
.PHONY: swagger | ||
swagger: | ||
swagger: swag | ||
swag fmt -g api.go | ||
swag init --v3.1 -g api.go | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,6 @@ yarn-debug.log* | |
yarn-error.log* | ||
package-lock.json | ||
|
||
dist/* | ||
!dist/README.md | ||
/history | ||
|
||
#editors | ||
|
File renamed without changes.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, why don't we build the web assets on CI VS having to locally build it and commit it? Things such as
npm install
are non-deterministic, meaning my local web build can be different from yours. In CI we can make sure we have reproducible builds via specific node+npm versions and commands such asnpm ci
for example.