chore: include generated assets in repo #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
changed the title
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
JGAntunes
reviewed
May 28, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
158
to
182
| check-web: | ||
| name: Check web | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Setup node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/* | ||
| - name: Install dependencies | ||
| working-directory: ./web | ||
| run: npm i | ||
| - name: Build | ||
| working-directory: ./web | ||
| run: npm run build | ||
| - name: Check web is up to date | ||
| run: | | ||
| git diff --exit-code --name-only | ||
| if [ $? -eq 0 ]; then | ||
| echo "Web is up to date" | ||
| else | ||
| echo "Web is out of date" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Alternatively, why don't we build the web assets on CI VS having to locally build it and commit it? Things such as npm install are non-deterministic, meaning my local web build can be different from yours. In CI we can make sure we have reproducible builds via specific node+npm versions and commands such as npm ci for example.
JGAntunes
reviewed
May 28, 2025
web/vite.config.ts
Outdated
Comment on lines
8
to
19
| plugins: [ | ||
| react(), | ||
| // Preserve README.md from .gitignore | ||
| viteStaticCopy({ | ||
| targets: [ | ||
| { | ||
| src: path.resolve(__dirname, './README.md'), | ||
| dest: './', | ||
| }, | ||
| ], | ||
| }), | ||
| ], |
There was a problem hiding this comment.
Could you explain why we need this?
Co-authored-by: João Antunes <[email protected]>
JGAntunes
approved these changes
May 28, 2025
sgalsaleh
approved these changes
May 28, 2025
|
Test failures are unrelated. Merging |
emosbaugh
deleted the
emosbaugh/sc-124145/build-and-include-web-in-ci-prod-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds generated assets to repo and checks that they are up to date or fails the CI run.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?