Skip to content

fix(apps/hermes): use last ip in the headers #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(apps/hermes): use last ip in the headers #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hermes/server/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/hermes/server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "hermes"
version = "0.8.5"
version = "0.8.6"
description = "Hermes is an agent that provides Verified Prices from the Pythnet Pyth Oracle."
edition = "2021"

Expand Down
4 changes: 3 additions & 1 deletion apps/hermes/server/src/api/ws.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ where
let requester_ip = headers
.get(state.ws.requester_ip_header_name.as_str())
.and_then(|value| value.to_str().ok())
.and_then(|value| value.split(',').next()) // Only take the first ip if there are multiple
// Only take the last ip if there are multiple. Note: if the service is behind multiple load balancers,
// this will be the ip the last balancer sees.
.and_then(|value| value.split(',').last())
.and_then(|value| value.parse().ok());

ws.max_message_size(MAX_CLIENT_MESSAGE_SIZE)
Expand Down
Loading