Skip to content

fix(apps/hermes): use last ip in the headers #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ali-bahjati
Copy link
Collaborator

Rationale

In the current implementation we use the first IP in the specified header to detect the user IP but some load balancers always append the IP to it and the first IP can be provider by the user.

Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 22, 2025 10:05am
component-library ⬜️ Ignored (Inspect) Apr 22, 2025 10:05am
entropy-debugger ⬜️ Ignored (Inspect) Apr 22, 2025 10:05am
insights ⬜️ Ignored (Inspect) Apr 22, 2025 10:05am
proposals ⬜️ Ignored (Inspect) Apr 22, 2025 10:05am
staking ⬜️ Ignored (Inspect) Apr 22, 2025 10:05am

@ali-bahjati
Copy link
Collaborator Author

closing because this behaviour might result blocking everyone in some setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants