Fix crash when a timed invoke happens for a large payload command. #38622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we don't pass the exchange through command handling, treating it as out-of-band state instead, we have to maintain that state on all codepaths that can lead to command handling. Also fixes timed writes, but those are not exercised right now. Fixes project-chip#38580
|
PR #38622: Size comparison from 4cbce7f to 890ad5a Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jamesharrow
approved these changes
Apr 26, 2025
andy31415
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we don't pass the exchange through command handling, treating it as out-of-band state instead, we have to maintain that state on all codepaths that can lead to command handling.
Also fixes timed writes, but those are not exercised right now.
Fixes #38580
Testing
Will be exercised by the tests being added in #38181