-
Notifications
You must be signed in to change notification settings - Fork 62
🌱 Add comments regarding external testing for preflight #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add comments regarding external testing for preflight #1957
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
+ Coverage 66.75% 66.78% +0.02%
==========================================
Files 75 75
Lines 6335 6337 +2
==========================================
+ Hits 4229 4232 +3
+ Misses 1842 1841 -1
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There've been a number of changes to the preflight pre-auth conditon message that have broken external tests. Those tests are being fixed but we want to ensure maintainers are cautious here. Signed-off-by: Todd Short <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bentito, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
e729569
into
operator-framework:main
There've been a number of changes to the preflight pre-auth conditon message that have broken external tests. Those tests are being fixed but we want to ensure maintainers are cautious here.
Description
Reviewer Checklist