Skip to content

🌱 Add comments regarding external testing for preflight #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 7, 2025

There've been a number of changes to the preflight pre-auth conditon message that have broken external tests. Those tests are being fixed but we want to ensure maintainers are cautious here.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner May 7, 2025 14:59
@openshift-ci openshift-ci bot requested review from anik120 and bentito May 7, 2025 14:59
Copy link

netlify bot commented May 7, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 4b237a4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/681b99d6c0d25c0008c28402
😎 Deploy Preview https://deploy-preview-1957--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (bfac51c) to head (4b237a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   66.75%   66.78%   +0.02%     
==========================================
  Files          75       75              
  Lines        6335     6337       +2     
==========================================
+ Hits         4229     4232       +3     
+ Misses       1842     1841       -1     
  Partials      264      264              
Flag Coverage Δ
e2e 45.19% <0.00%> (-0.02%) ⬇️
unit 56.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bentito bentito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
There've been a number of changes to the preflight pre-auth conditon
message that have broken external tests. Those tests are being fixed
but we want to ensure maintainers are cautious here.

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort force-pushed the preflight-comment branch from ac72bc6 to 4b237a4 Compare May 7, 2025 17:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@tmshort
Copy link
Contributor Author

tmshort commented May 7, 2025

/approve

Copy link

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bentito, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@trgeiger
Copy link
Contributor

trgeiger commented May 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e729569 into operator-framework:main May 7, 2025
22 checks passed
@tmshort tmshort deleted the preflight-comment branch May 7, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants