Skip to content

Commit 4b237a4

Browse files
committed
Add comments regarding external testing for preflight
There've been a number of changes to the preflight pre-auth conditon message that have broken external tests. Those tests are being fixed but we want to ensure maintainers are cautious here. Signed-off-by: Todd Short <[email protected]>
1 parent bfac51c commit 4b237a4

File tree

1 file changed

+2
-0
lines changed
  • internal/operator-controller/applier

1 file changed

+2
-0
lines changed

internal/operator-controller/applier/helm.go

+2
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,14 @@ func (h *Helm) runPreAuthorizationChecks(ctx context.Context, ext *ocv1.ClusterE
103103
}
104104
}
105105
slices.Sort(missingRuleDescriptions)
106+
// This phrase is explicitly checked by external testing
106107
preAuthErrors = append(preAuthErrors, fmt.Errorf("service account requires the following permissions to manage cluster extension:\n %s", strings.Join(missingRuleDescriptions, "\n ")))
107108
}
108109
if authErr != nil {
109110
preAuthErrors = append(preAuthErrors, fmt.Errorf("authorization evaluation error: %w", authErr))
110111
}
111112
if len(preAuthErrors) > 0 {
113+
// This phrase is explicitly checked by external testing
112114
return fmt.Errorf("pre-authorization failed: %v", errors.Join(preAuthErrors...))
113115
}
114116
return nil

0 commit comments

Comments
 (0)