Skip to content

filter check_mass_balance zeros with a floating point comparison #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2025
Merged

filter check_mass_balance zeros with a floating point comparison #1436

merged 3 commits into from
May 17, 2025

Conversation

jedforrest
Copy link
Contributor

@jedforrest jedforrest commented Apr 15, 2025 •
edited
Loading

Fixes #1435 by filtering out zeros in the reaction element dictionary using math.isclose.

cdiener
cdiener reviewed Apr 15, 2025
View reviewed changes
cdiener
cdiener approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks. CI failures are caused by an unrelated problem. Only missing the release notes.

@cdiener cdiener merged commit 9e82a6d into opencobra:devel May 17, 2025
6 of 7 checks passed
@cdiener
Copy link
Member

cdiener commented May 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdiener cdiener cdiener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] check_mass_balance fails for floating point coefficients
2 participants
@jedforrest @cdiener