-
Notifications
You must be signed in to change notification settings - Fork 137
fix: fix 2 cargo warnings #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -18,7 +18,7 @@ rmcp = { path = "../../crates/rmcp", features = [ | |||
"client", | |||
"transport-child-process", | |||
"transport-sse", | |||
], no-default-features = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was ignored by cargo because it should be default-features = false
.
@@ -17,7 +17,7 @@ readme = { workspace = true } | |||
crate-type = ["cdylib"] | |||
|
|||
[dependencies] | |||
wasi = { version = "0.14.2+wasi-0.2.4"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was also ignored by Cargo according to
warning: /home/runner/work/rust-sdk/rust-sdk/examples/wasi/Cargo.toml: version requirement `0.14.2+wasi-0.2.4` for dependency `wasi` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can fix the rest one warning latter. Thank you for PR.
This fixes three warnings that
cargo test
produced.Motivation and Context
Locally and in CI the following warnings were visible:
How Has This Been Tested?
I re-ran all tests and also manually "tested" (built)
rig-integration
via$ cd examples/righ-integration $ cargo build
For
rig-integration
I verified that settingdefault-features = false
will not be able to build the project, so that's why I removed it. Note thatdefault-features = false
is interpreted by Cargo while the settingno-default-features = true
was ignored.Breaking Changes
No
Types of changes
Checklist
Additional context