docs: simplify counter example #122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikhuijzer
force-pushed
the
rh/simplify-counter-example
branch
from
54f21f6 to
bc7d00f
Compare
rikhuijzer
force-pushed
the
rh/simplify-counter-example
branch
from
bc7d00f to
a9c1918
Compare
rikhuijzer
commented
Apr 10, 2025
| @@ -17,4 +17,4 @@ rmcp = { git = "https://github.com/modelcontextprotocol/rust-sdk", features = [ | |||
| "client", | |||
| "transport-child-process", | |||
| "transport-sse", | |||
| ], no-default-features = true } | |||
There was a problem hiding this comment.
This had no effect like in #112. Setting default-features = false does not compile so I just removed it.
There was a problem hiding this comment.
Sorry , I didn't meet this problem, could you pls provide more detail?
There was a problem hiding this comment.
Uhm yes I'll try. The setting no-default-features does not exists, so no-default-features = true is ignored by Cargo. The setting should be default-features = true, but if you set that the code does not compile. So that's why I removed it.
There was a problem hiding this comment.
The confusion might be because of cargo build --no-default-features. That is a valid option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought
_create_resource_textwas part of the public API, but noticed that it's only used inside this file. To make that more clear, I moved the function definition closer to the callsite.Motivation and Context
It makes the example a bit clearer.
How Has This Been Tested?
I manually ran the examples.
Breaking Changes
No
Types of changes
Checklist