vertexai|community|genai: Change the client_library_version to gapic_version in gapic client's info. #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-yang-google
force-pushed
the
gapic-version
branch
3 times, most recently
from
e07d5da to
3f6a0ce
Compare
|
Vertexai test: Community test: Genai test: |
lkuligin
requested changes
May 16, 2025
| return ClientInfo( | ||
| client_library_version=client_library_version, |
There was a problem hiding this comment.
let's keep both, please
we might rely on client_library_version in some other place
There was a problem hiding this comment.
just send both client_library_version and additionally gapic_version= client_library_version
| @@ -193,8 +193,8 @@ def test_get_user_agent_with_telemetry_env_variable( | |||
| ) -> None: | |||
| mock_version.return_value = "1.2.3" | |||
| mock_environ_get.return_value = True | |||
| client_lib_version, user_agent_str = get_user_agent(module="test-module") | |||
| assert client_lib_version == "1.2.3-test-module+remote_reasoning_engine" | |||
| gapic_version, user_agent_str = get_user_agent(module="test-module") | |||
There was a problem hiding this comment.
I don't think we need this change (as mentioned above)
shawn-yang-google
force-pushed
the
gapic-version
branch
from
3f6a0ce to
c17d7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Relevant issues
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes(optional)
Testing(optional)
Note(optional)