Skip to content

Commit 3f6a0ce

Browse files
[vertexai|community|genai] chore: Change the client_library_version to gapic_version
1 parent 0d40a4f commit 3f6a0ce

File tree

8 files changed

+31
-37
lines changed

8 files changed

+31
-37
lines changed

libs/community/langchain_google_community/_utils.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,12 @@ def get_user_agent(module: Optional[str] = None) -> Tuple[str, str]:
3535
langchain_version = metadata.version("langchain-google-community")
3636
except metadata.PackageNotFoundError:
3737
langchain_version = "0.0.0"
38-
client_library_version = (
39-
f"{langchain_version}-{module}" if module else langchain_version
40-
)
38+
gapic_version = f"{langchain_version}-{module}" if module else langchain_version
4139
if os.environ.get(_TELEMETRY_ENV_VARIABLE_NAME):
42-
client_library_version += f"+{_TELEMETRY_TAG}"
40+
gapic_version += f"+{_TELEMETRY_TAG}"
4341
return (
44-
client_library_version,
45-
f"langchain-google-community/{client_library_version}",
42+
gapic_version,
43+
f"langchain-google-community/{gapic_version}",
4644
)
4745

4846

@@ -55,9 +53,9 @@ def get_client_info(module: Optional[str] = None) -> "ClientInfo":
5553
Returns:
5654
google.api_core.gapic_v1.client_info.ClientInfo
5755
"""
58-
client_library_version, user_agent = get_user_agent(module)
56+
gapic_version, user_agent = get_user_agent(module)
5957
return ClientInfo(
60-
client_library_version=client_library_version,
58+
gapic_version=gapic_version,
6159
user_agent=user_agent,
6260
)
6361

libs/community/tests/unit_tests/test_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ def test_get_user_agent_with_telemetry_env_variable(
1212
) -> None:
1313
mock_version.return_value = "1.2.3"
1414
mock_environ_get.return_value = True
15-
client_lib_version, user_agent_str = get_user_agent(module="test-module")
16-
assert client_lib_version == "1.2.3-test-module+remote_reasoning_engine"
15+
gapic_version, user_agent_str = get_user_agent(module="test-module")
16+
assert gapic_version == "1.2.3-test-module+remote_reasoning_engine"
1717
assert user_agent_str == (
1818
"langchain-google-community/1.2.3-test-module+remote_reasoning_engine"
1919
)
@@ -26,6 +26,6 @@ def test_get_user_agent_without_telemetry_env_variable(
2626
) -> None:
2727
mock_version.return_value = "1.2.3"
2828
mock_environ_get.return_value = False
29-
client_lib_version, user_agent_str = get_user_agent(module="test-module")
30-
assert client_lib_version == "1.2.3-test-module"
29+
gapic_version, user_agent_str = get_user_agent(module="test-module")
30+
assert gapic_version == "1.2.3-test-module"
3131
assert user_agent_str == "langchain-google-community/1.2.3-test-module"

libs/genai/langchain_google_genai/_common.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,10 @@ def get_user_agent(module: Optional[str] = None) -> Tuple[str, str]:
129129
langchain_version = metadata.version("langchain-google-genai")
130130
except metadata.PackageNotFoundError:
131131
langchain_version = "0.0.0"
132-
client_library_version = (
133-
f"{langchain_version}-{module}" if module else langchain_version
134-
)
132+
gapic_version = f"{langchain_version}-{module}" if module else langchain_version
135133
if os.environ.get(_TELEMETRY_ENV_VARIABLE_NAME):
136-
client_library_version += f"+{_TELEMETRY_TAG}"
137-
return client_library_version, f"langchain-google-genai/{client_library_version}"
134+
gapic_version += f"+{_TELEMETRY_TAG}"
135+
return gapic_version, f"langchain-google-genai/{gapic_version}"
138136

139137

140138
def get_client_info(module: Optional[str] = None) -> "ClientInfo":
@@ -146,9 +144,9 @@ def get_client_info(module: Optional[str] = None) -> "ClientInfo":
146144
Returns:
147145
google.api_core.gapic_v1.client_info.ClientInfo
148146
"""
149-
client_library_version, user_agent = get_user_agent(module)
147+
gapic_version, user_agent = get_user_agent(module)
150148
return ClientInfo(
151-
client_library_version=client_library_version,
149+
gapic_version=gapic_version,
152150
user_agent=user_agent,
153151
)
154152

libs/genai/tests/unit_tests/test_common.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ def test_get_user_agent_with_telemetry_env_variable(
1212
) -> None:
1313
mock_version.return_value = "1.2.3"
1414
mock_environ_get.return_value = True
15-
client_lib_version, user_agent_str = get_user_agent(module="test-module")
16-
assert client_lib_version == "1.2.3-test-module+remote_reasoning_engine"
15+
gapic_version, user_agent_str = get_user_agent(module="test-module")
16+
assert gapic_version == "1.2.3-test-module+remote_reasoning_engine"
1717
assert user_agent_str == (
1818
"langchain-google-genai/1.2.3-test-module+remote_reasoning_engine"
1919
)
@@ -26,6 +26,6 @@ def test_get_user_agent_without_telemetry_env_variable(
2626
) -> None:
2727
mock_version.return_value = "1.2.3"
2828
mock_environ_get.return_value = False
29-
client_lib_version, user_agent_str = get_user_agent(module="test-module")
30-
assert client_lib_version == "1.2.3-test-module"
29+
gapic_version, user_agent_str = get_user_agent(module="test-module")
30+
assert gapic_version == "1.2.3-test-module"
3131
assert user_agent_str == "langchain-google-genai/1.2.3-test-module"

libs/genai/tests/unit_tests/test_embeddings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_integration_initialization() -> None:
2828
client_info = mock_prediction_service.call_args.kwargs["client_info"]
2929
assert "langchain-google-genai" in client_info.user_agent
3030
assert "GoogleGenerativeAIEmbeddings" in client_info.user_agent
31-
assert "GoogleGenerativeAIEmbeddings" in client_info.client_library_version
31+
assert "GoogleGenerativeAIEmbeddings" in client_info.gapic_version
3232

3333
with patch(
3434
"langchain_google_genai._genai_extension.v1betaGenerativeServiceClient"

libs/vertexai/langchain_google_vertexai/_utils.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,10 @@ def get_user_agent(module: Optional[str] = None) -> Tuple[str, str]:
9696
langchain_version = metadata.version("langchain-google-vertexai")
9797
except metadata.PackageNotFoundError:
9898
langchain_version = "0.0.0"
99-
client_library_version = (
100-
f"{langchain_version}-{module}" if module else langchain_version
101-
)
99+
gapic_version = f"{langchain_version}-{module}" if module else langchain_version
102100
if os.environ.get(_TELEMETRY_ENV_VARIABLE_NAME):
103-
client_library_version += f"+{_TELEMETRY_TAG}"
104-
return client_library_version, f"langchain-google-vertexai/{client_library_version}"
101+
gapic_version += f"+{_TELEMETRY_TAG}"
102+
return gapic_version, f"langchain-google-vertexai/{gapic_version}"
105103

106104

107105
def get_client_info(module: Optional[str] = None) -> "ClientInfo":
@@ -113,9 +111,9 @@ def get_client_info(module: Optional[str] = None) -> "ClientInfo":
113111
Returns:
114112
google.api_core.gapic_v1.client_info.ClientInfo
115113
"""
116-
client_library_version, user_agent = get_user_agent(module)
114+
gapic_version, user_agent = get_user_agent(module)
117115
return ClientInfo(
118-
client_library_version=client_library_version,
116+
gapic_version=gapic_version,
119117
user_agent=user_agent,
120118
)
121119

libs/vertexai/tests/unit_tests/test_chat_models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ def test_init_client(model: str, location: str) -> None:
125125
assert client_options.api_endpoint == f"{location}-aiplatform.googleapis.com"
126126
assert "langchain-google-vertexai" in client_info.user_agent
127127
assert "ChatVertexAI" in client_info.user_agent
128-
assert "langchain-google-vertexai" in client_info.client_library_version
129-
assert "ChatVertexAI" in client_info.client_library_version
128+
assert "langchain-google-vertexai" in client_info.gapic_version
129+
assert "ChatVertexAI" in client_info.gapic_version
130130
assert llm.full_model_name == (
131131
f"projects/test-proj/locations/{location}/publishers/google/models/gemini-1.0-pro-001"
132132
)

libs/vertexai/tests/unit_tests/test_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ def test_get_user_agent_with_telemetry_env_variable(
193193
) -> None:
194194
mock_version.return_value = "1.2.3"
195195
mock_environ_get.return_value = True
196-
client_lib_version, user_agent_str = get_user_agent(module="test-module")
197-
assert client_lib_version == "1.2.3-test-module+remote_reasoning_engine"
196+
gapic_version, user_agent_str = get_user_agent(module="test-module")
197+
assert gapic_version == "1.2.3-test-module+remote_reasoning_engine"
198198
assert user_agent_str == (
199199
"langchain-google-vertexai/1.2.3-test-module+remote_reasoning_engine"
200200
)
@@ -207,6 +207,6 @@ def test_get_user_agent_without_telemetry_env_variable(
207207
) -> None:
208208
mock_version.return_value = "1.2.3"
209209
mock_environ_get.return_value = False
210-
client_lib_version, user_agent_str = get_user_agent(module="test-module")
211-
assert client_lib_version == "1.2.3-test-module"
210+
gapic_version, user_agent_str = get_user_agent(module="test-module")
211+
assert gapic_version == "1.2.3-test-module"
212212
assert user_agent_str == "langchain-google-vertexai/1.2.3-test-module"

0 commit comments

Comments
 (0)