Skip to content

Update default output of bin/release #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

Update default output of bin/release #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52a8479
Track if Procfile is used for web process
colincasey Apr 23, 2025
4d4ceed
Update default output of bin/release
colincasey Apr 23, 2025
bd475c9
Update release script to not contribute a default process type if any…
colincasey May 13, 2025
442224f
Merge branch 'main' into update_release_output
colincasey May 13, 2025
15d2523
Update CHANGELOG.md
colincasey May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Release script will not contribute a default process type if any `mcp` entries are present in the Procfile. ([#1404](https://github.com/heroku/heroku-buildpack-nodejs/pull/1404))

## [v292] - 2025-05-09

Expand Down
11 changes: 10 additions & 1 deletion bin/release
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
#!/usr/bin/env bash
# bin/release <build-dir>

cat << EOF
BUILD_DIR=${1:-}

if [ -f "$BUILD_DIR/Procfile" ] && grep -q -e "^\s*mcp.*:" "$BUILD_DIR/Procfile"; then
cat << EOF
addons: []
default_process_types: {}
EOF
else
cat << EOF
addons: []
default_process_types:
web: npm start
EOF
fi
1 change: 1 addition & 0 deletions bin/report
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ kv_pair_string "package_manager_request" "$(read_json "$BUILD_DIR/package.json"

# is a procfile with a web process used?
kv_pair "procfile_with_web_process" "$(has_procfile_with_web_process)"

# is a procfile used?
if [ -f "$BUILD_DIR/Procfile" ]; then
kv_pair "procfile_used" "true"
Expand Down