Skip to content

Update default output of bin/release #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

Update default output of bin/release #1404

merged 5 commits into from
May 13, 2025

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Apr 23, 2025 •
edited
Loading

Update release script to not contribute a default process type if any mcp entries are present in the Procfile

@colincasey
Track if Procfile is used for web process
52a8479
@colincasey
Update default output of bin/release
4d4ceed 
Only output a default web process if there is no Procfile present.
@colincasey colincasey self-assigned this Apr 23, 2025
Base automatically changed from add_metrics_on_procfile_usage to main April 23, 2025 23:13
@colincasey colincasey requested a review from jabrown85 May 13, 2025 17:44
@colincasey colincasey marked this pull request as ready for review May 13, 2025 17:44
@colincasey colincasey requested a review from a team as a code owner May 13, 2025 17:44
jabrown85
jabrown85 approved these changes May 13, 2025
View reviewed changes
Copy link

@jabrown85 jabrown85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me to start with!

joshwlewis
joshwlewis approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@joshwlewis joshwlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, and not awful (compared to other options we discussed!)

@colincasey colincasey merged commit c0cc0de into main May 13, 2025
9 checks passed
@colincasey colincasey deleted the update_release_output branch May 13, 2025 20:39
@heroku-linguist heroku-linguist bot mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrown85 jabrown85 jabrown85 approved these changes

@joshwlewis joshwlewis joshwlewis approved these changes

Assignees

@colincasey colincasey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colincasey @jabrown85 @joshwlewis