fix: Ensure containers are tagged by release tag #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue filecoin-project#934 where the container publishing CI workflow only tagged containers by commit SHA and not by the release tag. The primary issue was an incorrect nesting of the `workflow_run` trigger within the `push` trigger in the `.github/workflows/publish-ghcr.yml` file. This prevented the workflow from being correctly triggered upon the completion of the `Releaser` workflow, which is responsible for creating Git tags and GitHub releases. This change corrects the workflow trigger syntax, ensuring that the container build and publish workflow runs after a release is made, allowing it to use the semantic version tag for the container image.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the trigger configuration in the GitHub Actions workflow so that the publish-ghcr job runs after the Releaser workflow completes, allowing container images to be tagged by the released semantic version.
- Moved
workflow_runtrigger out of thepushblock into the top-levelonsection - Ensures the publish-ghcr workflow is invoked when the Releaser workflow finishes
Kubuxu
approved these changes
May 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #934 where the container publishing CI workflow only tagged containers by commit SHA and not by the release tag.
The primary issue was an incorrect nesting of the
workflow_runtrigger within thepushtrigger in the.github/workflows/publish-ghcr.ymlfile. This prevented the workflow from being correctly triggered upon the completion of theReleaserworkflow, which is responsible for creating Git tags and GitHub releases.This change corrects the workflow trigger syntax, ensuring that the container build and publish workflow runs after a release is made, allowing it to use the semantic version tag for the container image.