Skip to content

Containers are not tagged by release tag when a new release is made #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masih opened this issue Apr 3, 2025 · 3 comments
Open

Containers are not tagged by release tag when a new release is made #934

masih opened this issue Apr 3, 2025 · 3 comments
Labels
good first issue Good for newcomers

Comments

@masih
Copy link
Member

masih commented Apr 3, 2025

Looks like the container publishing CI workflow only tags containers by commit SHA. Investigate why on release containers are not tagged by the release tag.

@github-project-automation github-project-automation bot moved this to Todo in F3 Apr 3, 2025
@BigLep BigLep added this to the MX: Priority and sequencing TBD milestone Apr 7, 2025
@BigLep BigLep added the good first issue Good for newcomers label Apr 7, 2025
@BigLep
Copy link
Member

BigLep commented Apr 7, 2025

Per 2025-04-07 standup, this isn't critical. I'm moving this out of the active milestones but obviously great if someone just does it.

@Likhil45
Copy link

Likhil45 commented Apr 9, 2025

Hi @BigLep,

Can i work on this issue?

@masih
Copy link
Member Author

masih commented Apr 10, 2025

Feel free to 👍

sumitvekariya added a commit to sumitvekariya/go-f3 that referenced this issue May 24, 2025
This commit fixes issue filecoin-project#934 where the container publishing CI workflow
only tagged containers by commit SHA and not by the release tag.

The primary issue was an incorrect nesting of the `workflow_run` trigger
within the `push` trigger in the `.github/workflows/publish-ghcr.yml` file.
This prevented the workflow from being correctly triggered upon the completion
of the `Releaser` workflow, which is responsible for creating Git tags
and GitHub releases.

This change corrects the workflow trigger syntax, ensuring that the
container build and publish workflow runs after a release is made,
allowing it to use the semantic version tag for the container image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants