Skip to content

chore: Use conda-forge r-xslt for all platforms #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 29, 2025

@matthewfeickert matthewfeickert self-assigned this Apr 29, 2025
Copy link

github-actions bot commented Apr 29, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/reproducible-ml-workflows/compare/md-outputs..md-outputs-PR-3

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-04-29 21:09:55 +0000

github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
@matthewfeickert
Copy link
Member Author

Hm. Trying to use r-tinkr 0.2.0 from conda-forge results in a purr::map error.

$ pixi run serve
✨ Pixi task (serve): Rscript -e "sandpaper::serve()": (Serve the lesson)
Error in `purrr::map()`:
ℹ In index: 1.
ℹ With name: introduction.md.
Caused by error in `self$frontmatter <- ep$frontmatter`:
! cannot add bindings to a locked environment
Backtrace:

  1. ├─sandpaper::serve()
  2. │ └─sandpaper (local) rend(this_path)
  3. │   └─sandpaper::build_lesson(f, preview = FALSE, quiet = quiet)
  4. │     └─sandpaper::validate_lesson(path, quiet = quiet)
  5. │       └─sandpaper:::this_lesson(path)
  6. │         └─.store$set(path)
  7. │           └─pegboard::Lesson$new(path, jekyll = FALSE)
  8. │             └─pegboard (local) initialize(...)
  9. │               └─pegboard:::read_sandpaper_lesson(path, ...)
 10. │                 └─pegboard:::read_markdown_files(...)
 11. │                   └─purrr::map(.x = the_files, .f = Episode$new, ...)
 12. │                     └─purrr:::map_("list", .x, .f, ..., .progress = .progress)
 13. │                       ├─purrr:::with_indexed_errors(...)
 14. │                       │ └─base::withCallingHandlers(...)
 15. │                       ├─purrr:::call_with_cleanup(...)
 16. │                       └─R6 (local) .f(.x[[i]], ...)
 17. │                         └─pegboard (local) initialize(...)
 18. └─base::.handleSimpleError(...)
 19.   └─purrr (local) h(simpleError(msg, call))
 20.     └─cli::cli_abort(...)
 21.       └─rlang::abort(...)
Execution halted

this isn't present if tinkr is built from source locally

also installing the dependency ‘tinkr’

trying URL 'https://carpentries.r-universe.dev/src/contrib/tinkr_0.2.0.9002.tar.gz'
Content type 'application/gzip' length 238372 bytes (232 KB)
==================================================
downloaded 232 KB

...
* installing *source* package ‘tinkr’ ...
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
*** copying figures
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (tinkr)

@matthewfeickert matthewfeickert changed the title chore: Add r-tinkr dependency to pixi environment chore: Use conda-forge r-xslt for all platforms Apr 29, 2025
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
@matthewfeickert matthewfeickert merged commit c260131 into carpentries-incubator:main Apr 29, 2025
3 checks passed
@matthewfeickert matthewfeickert deleted the chore/add-r-tinkr branch April 29, 2025 21:11
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
Auto-generated via `{sandpaper}`
Source  : c260131
Branch  : main
Author  : Matthew Feickert <[email protected]>
Time    : 2025-04-29 21:11:35 +0000
Message : chore: Use conda-forge r-xslt for all platforms (#3)

* As full multi-platform support was added to `r-xslt` in conda-forge/r-xslt-feedstock#12
  it can be used across all target platforms.
* Update lock file.
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
Auto-generated via `{sandpaper}`
Source  : b6136de
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-04-29 21:12:14 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c260131
Branch  : main
Author  : Matthew Feickert <[email protected]>
Time    : 2025-04-29 21:11:35 +0000
Message : chore: Use conda-forge r-xslt for all platforms (#3)

* As full multi-platform support was added to `r-xslt` in conda-forge/r-xslt-feedstock#12
  it can be used across all target platforms.
* Update lock file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant