Fix mesh deduplication for meshes with different materials #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses issue #836 by fixing the mesh deduplication problem for meshes with different materials. The key changes include:
- Invoking CreateMeshMaterials asynchronously for shared meshes in ConstructMesh.
- Refactoring the call to CreateMaterials for each primitive.
- Updating the assignment of LoadedMesh in UnityMeshData to cover all cache entries referencing the same data.
Comments suppressed due to low confidence (1)
Runtime/Scripts/SceneImporter/ImporterMeshes.cs:725
- [nitpick] Verify that using reference equality for UnityMeshData in the loop reliably identifies shared meshes. If duplicate instances could exist, consider an alternative approach to ensure all related MeshCache entries are updated correctly.
// Assign the loaded mesh to all MeshCache entries that reference the same UnityMeshData
… we override now the UnityMeshData and LoadedMesh to fix the issue
hybridherbst
force-pushed
the
fix/mesh-deduplication-material-losing
branch
from
7cc3021 to
f800bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836.
Instead of overriding the node mesh id for shared meshes, we override now the UnityMeshData and LoadedMesh to fix the issue.