Skip to content

Reaction elements #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Reaction elements #25

merged 2 commits into from
May 8, 2025

Conversation

JR-1991
Copy link
Member

@JR-1991 JR-1991 commented May 8, 2025

This PR further splits the Reaction object's ReactionElement into reactants and products. Consequently, stoichiometry is no longer the basis for determining direction but rather the property to which the ReactionElement is assigned.

@JR-1991 JR-1991 requested a review from haeussma May 8, 2025 13:39
@JR-1991 JR-1991 self-assigned this May 8, 2025
@JR-1991 JR-1991 added this to EnzymeML May 8, 2025
@JR-1991 JR-1991 added the enhancement New feature or request label May 8, 2025
@JR-1991 JR-1991 moved this to Ready for Review in EnzymeML May 8, 2025
@JR-1991 JR-1991 merged commit 507dd6b into main May 8, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in EnzymeML May 8, 2025
@JR-1991 JR-1991 deleted the reaction-elements branch May 8, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants