Skip to content

Current definition of stoichiometry and role of ReactionElement inconclusive #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haeussma opened this issue Mar 6, 2025 · 3 comments
Assignees

Comments

@haeussma
Copy link
Member

haeussma commented Mar 6, 2025

Currently, the role and the stoichiometry of an RectionElement is implicitly defined through the stochiometry field. This is ambiguous, since to express that the element is the a substrate one would define stoichiometry = -1 without knowing if the stoichiometry of the substrate truly is 1.

Thus, I recommend adding an additional enum field role (type ReactionRole) to the ReactionElement object.
The ReactionRole contains enums for substrate and product.

@haeussma haeussma self-assigned this Mar 6, 2025
@haeussma haeussma added this to EnzymeML Mar 6, 2025
@haeussma haeussma moved this to Todo in EnzymeML Mar 6, 2025
@JR-1991
Copy link
Member

JR-1991 commented Mar 6, 2025

Wouldn't it be easier to roll back to explicit arrays for products and reactants?

@haeussma
Copy link
Member Author

haeussma commented Mar 7, 2025

Like this:

Reaction

The Reaction object represents a chemical or enzymatic reaction and holds the different species and modifiers that are part of the reaction.

  • id: Identifier
    • Description: Unique identifier of the reaction.
    • Term: schema:identifier
  • name: string
    • Description: Name of the reaction.
  • reversible: boolean
    • Description: Whether the reaction is reversible or irreversible. Default is False.
    • Default: False
  • substrates: ReactionElement[]
    • Description: Substrates of the Reaction
  • products: ReactionElement[]
    • Description: Products of the Reaction
  • modifiers: Identifier[]
    • Description: List of species ids that are not consumed or build-up but influence the reaction.
  • kinetic_law: Equation
    • Description: Mathematical expression of the reaction.
  • species: ReactionElement[]
    • Description: List of reaction elements that are part of the reaction.

ReactionElement

  • species_id: str
    • Description: Identifier of the species.
    • Term: schema:identifier
  • stoichiometry: float
    • Description: Stoichiometry of the species within the reaction.

@JR-1991
Copy link
Member

JR-1991 commented May 8, 2025

Fixed in #25

@JR-1991 JR-1991 closed this as completed May 8, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in EnzymeML May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants