Skip to content

feat(gpu): add support for a custom device selection on multi-gpu mode #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(gpu): add support for a custom device selection on multi-gpu mode #2245

wants to merge 6 commits into from

Conversation

pdroalves
Copy link
Contributor

@pdroalves pdroalves commented Apr 7, 2025 •
edited
Loading

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/960

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Apr 7, 2025
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch 2 times, most recently from 19c6c2e to 3ba3139 Compare April 9, 2025 15:46
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch from 3ba3139 to 46e4f39 Compare April 9, 2025 17:08
tmontaigu
tmontaigu reviewed Apr 11, 2025
View reviewed changes
tfhe/src/high_level_api/keys/server.rs
@@ -341,10 +342,10 @@ impl Named for CompressedServerKey {
}

#[cfg(feature = "gpu")]
#[derive(Clone)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the derive

tmontaigu
tmontaigu reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@tmontaigu tmontaigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom case in the CudaStreamPools is not able to handle all possible cases but for now it should be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdroalves @tmontaigu