Add new attachment handler for opening attachments and viewing them in neovim #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, attachments could only be opened externally using `xdg-open`. This update adds an option to view attachments directly in a Neovim buffer, allowing users to preview text-based attachments without leaving Neovim. Attachments like plain text, markdown, and PDFs (if converted) can now be displayed in a buffer
BREAKING CHANGE: The `open_cmd` config option has been renamed to `open_handler` to align with the `view_handler` config option. It is now a callback function. Users will need to update their configuration to use `open_handler` instead of `open_cmd`.
The README configuration options now show that the handler config options are callback functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new attachment handlers to improve how attachments are opened and viewed:
open_handler: replaces the oldopen_cmdconfig option and is a callback function to open attachments externally. By default, it calls xdg-open, just like the old setup.view_handler: a new config option which is a callback function for viewing attachments directly inside Vim. By default it runs a view-handler shell command, which you can customize.This change makes it easier to handle attachments in different ways depending on the context, either externally or within Vim.
By making them callback function it gives users the option to handle opening or viewing attachment entirely within their lua config.
I included a example shell script in the readme for
view-handler. All it needs to do is to convert the file to text.This PR is a breaking change as it removes the old
open_cmd!