Update cookieStore WPTs to not append "/" to the path attribute #52572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove this behavior for better interoperability with document.cookie and the Set-Cookie header. This logic was added in https://chromium-review.googlesource.com/c/chromium/src/+/2131031 but it is unclear why that was done (per WICG/cookie-store#244). This change additionally updates the set/delete test cleanup methods to use the `Set-Cookie` header instead of `cookieStore.delete` to delete cookies to avoid a dependency on the API being tested. Bug: 402779102 Change-Id: I50fea05101c839f55736e7f3c958c919dd119f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6520094 Auto-Submit: Anusha Muley <[email protected]> Reviewed-by: Chris Fredrickson <[email protected]> Reviewed-by: Dylan Cutler <[email protected]> Commit-Queue: Dylan Cutler <[email protected]> Commit-Queue: Anusha Muley <[email protected]> Cr-Commit-Position: refs/heads/main@{#1460844}
wpt-pr-bot
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this behavior for better interoperability with document.cookie
and the Set-Cookie header. This logic was added in
https://chromium-review.googlesource.com/c/chromium/src/+/2131031 but it
is unclear why that was done (per
WICG/cookie-store#244).
This change additionally updates the set/delete test cleanup methods to
use the
Set-Cookieheader instead ofcookieStore.deleteto deletecookies to avoid a dependency on the API being tested.
Bug: 402779102
Change-Id: I50fea05101c839f55736e7f3c958c919dd119f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6520094
Auto-Submit: Anusha Muley <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Reviewed-by: Dylan Cutler <[email protected]>
Commit-Queue: Dylan Cutler <[email protected]>
Commit-Queue: Anusha Muley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1460844}