Skip to content

[V1] Add VLLM_ALLOW_INSECURE_SERIALIZATION env var #17490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

russellb
Copy link
Member

Update vllm.v1.serial_utils to have an environment variable that can
be used to turn the pickle fallback back on in code paths where we have
it off by default. This is to provide an escape hatch in case something
breaks that we did not expect.

The changes to the code base should be roughly:

  1. Change instances of the encoder/decoder to have allow_pickle=False.
  2. Fix what breaks.
  3. Merge, knowing users have a way to unbreak it if necessary, using
    the environment variable.
  4. Someday, remove pickle support completely. (I can dream, right?)

Follow-up to #17427.

Signed-off-by: Russell Bryant [email protected]

Update `vllm.v1.serial_utils` to have an environment variable that can
be used to turn the pickle fallback back on in code paths where we have
it off by default. This is to provide an escape hatch in case something
breaks that we did not expect.

The changes to the code base should be roughly:

1. Change instances of the encoder/decoder to have `allow_pickle=False`.
2. Fix what breaks.
3. Merge, knowing users have a way to unbreak it if necessary, using
   the environment variable.
4. Someday, remove pickle support completely. (I can dream, right?)

Follow-up to vllm-project#17427.

Signed-off-by: Russell Bryant <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant