Skip to content

feat(plugin-vue): use transformWithOxc if rolldown-vite is detected #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

TheAlexLichter
Copy link
Contributor

@TheAlexLichter TheAlexLichter commented May 1, 2025

Description

When using rolldown-vite, one needs to install esbuild at the moment as transformWithEsbuild is used. Instead, this PR uses the exported transformWithOxc function if available.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented May 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@584
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@584

commit: 5586694

@sapphi-red sapphi-red added the p3-significant 🔨 High priority enhancement (priority) label May 2, 2025
TheAlexLichter and others added 2 commits May 2, 2025 12:38
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sapphi-red sapphi-red merged commit 6ac8e3a into vitejs:main May 9, 2025
9 checks passed
@TheAlexLichter TheAlexLichter deleted the perf/rolldown-vite-use-oxc branch May 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant 🔨 High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants