blocking and interruptible on Scala Native
#4378
Conversation
|
Also fixes #4323 |
It is! Edit: caveat, it landed in SN 0.5.7, which we are struggling to upgrade to. |
| private[effect] object InterruptThrowable { | ||
| def apply(t: Throwable): Boolean = t match { | ||
| case _: InterruptedException => true | ||
| case _: ClosedByInterruptException => true |
There was a problem hiding this comment.
ClosedByInterruptException also landed in SN 0.5.7.
There was a problem hiding this comment.
Le sigh… Well, we'll remove my shims when we do.
| ticked("realTimeInstant should return an Instant constructed from realTime") { | ||
| implicit ticker => | ||
| val op = for { | ||
| now <- IO.realTimeInstant | ||
| realTime <- IO.realTime | ||
| } yield now.toEpochMilli == realTime.toMillis | ||
|
|
||
| assertCompleteAs(op, true) | ||
| } |
There was a problem hiding this comment.
We can remove the duplicate test from the Native-specific test suite:
| case ex: ClosedByInterruptException => throw ex | ||
| case t if InterruptThrowable(t) => throw t |
There was a problem hiding this comment.
Was the lack of InterruptedException here an oversight? Otherwise it seems like this is changing the semantic 🤔
There was a problem hiding this comment.
It's incorporated in the matcher
There was a problem hiding this comment.
Sorry, I think that was unclear: the previous matcher checked only for ClosedByInterruptException, but the new matcher now checks for both ClosedByInterruptException and InterruptedException. That's the change in semantic I'm referring to.
Fixes #4331
Fixes #4374
Closes #4360
This ports
interruptibleandblockingto the shared JVM/Native cross-build structure. I had to split apartIOCompaniona bit more since theCompletableFuturestuff is still JVM-only. Is that implemented on SN now? I'm assuming not. The other weird caveat came from the specialClosedByInterruptExceptionsemantics on JVM and its nonexistence on Native.