chore: fix OS detection with uname -s
#4346
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the
uname
command in the script could return different values on different systems, leading to potential issues when detecting macOS. To ensure more reliable OS detection, I've updated the check to useuname -s
, which provides the correct system name and accurately identifies macOS. This change will improve the script's compatibility across various platforms.How to test
uname -s
check correctly identifies macOS without issues on other systems.Types of changes
Checklist