Skip to content

chore: fix OS detection with uname -s #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mdqst
Copy link

@mdqst mdqst commented Apr 1, 2025

Description

I noticed that the uname command in the script could return different values on different systems, leading to potential issues when detecting macOS. To ensure more reliable OS detection, I've updated the check to use uname -s, which provides the correct system name and accurately identifies macOS. This change will improve the script's compatibility across various platforms.

How to test

  1. Run the script on different operating systems (e.g., macOS, Linux).
  2. Ensure that the uname -s check correctly identifies macOS without issues on other systems.
  3. Verify that the script runs successfully and builds/upload assets as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

@satoshiotomakan
Copy link
Collaborator

Hi @mdqst, could you please replace all uname usages within tools directory?

@mdqst
Copy link
Author

mdqst commented Apr 1, 2025

satoshiotomakan

satoshiotomakan, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants