Skip to content

Fix ppc64le builds #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

jmontleon
Copy link
Contributor

@jmontleon jmontleon commented Aug 6, 2023

Fixes #4

I think clang is going to be a challenge to get working on powerpc. If I understand correctly from conversations elsewhere it brings its own altivec.h on this platform which causes lots of pain.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97163
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239266

The two new patches come from:
pytorch/pytorch@bb0b283
pytorch/pytorch#98511 (not merged yet)

Also included the missing implicit syscall patch from the s390x PR.

https://copr.fedorainfracloud.org/coprs/jmontleon/pytorch/build/6245649/ shows results for the version of the spec in this PR

@jmontleon jmontleon marked this pull request as draft August 6, 2023 13:17
@jmontleon
Copy link
Contributor Author

jmontleon commented Aug 6, 2023

It looks like when building without cpuinfo libclog.a gets built on aarch64 and ppx64le from third_party/cpuinfo/deps/clog. With cpuinfo on x86_64 and aarch64 it looks like it still comes from third_party/QNNPACK/deps/clog, but that's not the case on ppc64le and s390x so we'll need a conditional to cover this. Testing:

https://copr.fedorainfracloud.org/coprs/jmontleon/pytorch/build/6246062/

@jmontleon jmontleon force-pushed the fix-ppc64le-builds branch from e2ef4a0 to 5332a7f Compare August 6, 2023 14:33
@jmontleon
Copy link
Contributor Author

Had to do the same for the devel package, of course: https://copr.fedorainfracloud.org/coprs/jmontleon/pytorch/build/6246123/

@jmontleon jmontleon marked this pull request as ready for review August 6, 2023 16:43
@trixirt trixirt merged commit e860204 into trixirt:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ppc64le and s390x builds if possible
2 participants