Skip to content

Fix ppc64le and s390x builds if possible #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmontleon opened this issue Aug 2, 2023 · 6 comments · Fixed by #7
Closed

Fix ppc64le and s390x builds if possible #4

jmontleon opened this issue Aug 2, 2023 · 6 comments · Fixed by #7

Comments

@jmontleon
Copy link
Contributor

Builds are failing on ppc64le and s390x.

I see a number of fixes going into the pytorch repo to address build issues on these architectures, but I am uncertain if we should expect successful builds at this time. I wanted to build with main today to see if there has been any improvement since 2.0.1, but there is an issue confirmed on status.fedoraproject.org with Copr so I'll have to wait to see.

@jmontleon
Copy link
Contributor Author

At least part seems to be the change in clang 16 wrt to Wimplicit-function-declaration
https://www.redhat.com/en/blog/new-warnings-and-errors-clang-16

Though that doesn't explain the clang 15 build errors on rhel 9/epel.

@jmontleon
Copy link
Contributor Author

I filed an issue against cpuinfo pytorch/cpuinfo#171 to see if we can get a hand with a proper fix for this.

The clang 15 s390x build looks like it might finish successfully, so if we can get past this maybe the others will work as well.

@jmontleon
Copy link
Contributor Author

I believe there is a small fix required to cpuinfo. I've update the issue on the git repo. This fixes s390x builds and partially fixes ppc64le builds. I'll submit a PR with the patch here shortly, once I've confirmed it's not unexpectedly breaking any other targets.

@jmontleon
Copy link
Contributor Author

I believe this fixes another ppc64le issue. The build is progressing further; will need to see if it actually finishes.
pytorch/pytorch#98511

I've also been making most my attempts on main, so I need to determine whether there's anything else between 2.0.1 and main needed for builds to work.

@jmontleon
Copy link
Contributor Author

jmontleon commented Aug 4, 2023

We're also seeing this failure, for which it doesn't look like there is a solution yet.
pytorch/pytorch#91936

This was referenced Aug 5, 2023
@jmontleon
Copy link
Contributor Author

@trixirt I saw you have cpuinfo built in rawhide over at https://src.fedoraproject.org/rpms/cpuinfo

Frustratingly, even though cpuinfo doesn't work on s390x and ppc64le, as far as I can tell it compiles fine and remains a dependency of pytorch. Would you be OK with a PR against the repo to enable and fix the builds for other archs?

@trixirt trixirt closed this as completed in #7 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant