Skip to content

TINY-11907: add support for 'disabled' property #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

TINY-11907: add support for 'disabled' property #414

wants to merge 6 commits into from
+206 −12

Conversation

michalnieruchalski-tiugo
Copy link

No description provided.

@michalnieruchalski-tiugo michalnieruchalski-tiugo marked this pull request as ready for review May 5, 2025 11:10
@michalnieruchalski-tiugo michalnieruchalski-tiugo requested a review from a team as a code owner May 5, 2025 11:10
@michalnieruchalski-tiugo michalnieruchalski-tiugo requested review from spocke, TheSpyder and ltrouton and removed request for a team May 5, 2025 11:10
@hamza0867 hamza0867 requested review from a team, lorenzo-pomili, HAFRMO and ztomaszyk and removed request for a team May 6, 2025 08:13
tiny-ben-tran
tiny-ben-tran reviewed May 8, 2025
View reviewed changes
Copy link

@tiny-ben-tran tiny-ben-tran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I like that the changes also support TinyMCE < 7.6. By the way, the version should be updated

  • [ ] Pump the minor version in package.json

@michalnieruchalski-tiugo
Copy link
Author

Looks great. I like that the changes also support TinyMCE < 7.6. By the way, the version should be updated

  • Pump the minor version in package.json

The current released version of angular integration is 8.0.1. The version in our package.json is 9.0.0-rc. We have some breaking changes that were prepared some time ago and haven't been released. I figured, we can release it together with this change therefore there's no need to bump the minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza0867 hamza0867 hamza0867 left review comments

@tiny-ben-tran tiny-ben-tran tiny-ben-tran approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

@lorenzo-pomili lorenzo-pomili Awaiting requested review from lorenzo-pomili lorenzo-pomili was automatically assigned from tinymce/high-velocity

@HAFRMO HAFRMO Awaiting requested review from HAFRMO HAFRMO was automatically assigned from tinymce/high-velocity

@ztomaszyk ztomaszyk Awaiting requested review from ztomaszyk ztomaszyk was automatically assigned from tinymce/high-velocity

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalnieruchalski-tiugo @hamza0867 @tiny-ben-tran