-
Notifications
You must be signed in to change notification settings - Fork 1
feat: fully configurable app config da #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
{ | ||
"ibmcloud_api_key": $VALIDATION_APIKEY, | ||
"app_config_tags": $TAGS, | ||
"existing_resource_group_name": "geretain-test-app-config" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should have all required inputs to run your code. I think you need region and service name here.
"existing_resource_group_name", "geretain-test-app-config"
may not be existing one, so you should use "geretain-test-resources"
Prefix also should be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added prefix and region . I think service is not needed here ?
|
|
Regarding tests (DA test and upgradeDA test):
|
@maheshwarishikha |
@mukulpalit-ibm just change the plan used in the example and run tests in parallel |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukulpalit-ibm #214 has just been merged. Can you also expose this new feature in the DA please?
mark_ready: true | ||
install_type: fullstack | ||
scc: | ||
instance_id: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this 1c7d5f78-9262-44c3-b779-b28fe4d88c37
as instance_id
Description
Issue
Sample Catalog for DA


Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers