-
Notifications
You must be signed in to change notification settings - Fork 895
Add int16 support to PACK/UNPACK #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure what's the deal with the failing CI |
"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days." |
Needs review |
"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days." |
Needs review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andresovela Thank you for your interest in TFLM (LRTM) and for submitting this PR!
Also, thank you for your persistence and perseverance.
This change looks good. Please make sure to merge with the latest main branch so there are no conflicts.
Also, another Google procedural requirement: All changed files should have the copyright year set the to current year (I know you submitted this last year). Only the current year should appear in the copyright.
Addressed concerns :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suleshahid Everything looks good here.
Sorry for delayed review! |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks. You may have to fix your CI before adding the pull request to the queue again. |
Ah, seems like Unpack int16 support was added in #3028 . Could you refactor? |
Hi @ddavis-2015, unfortunately priorities have changed at work and I no longer have time to work on this. Feel free to close the PR if it's already outdated. |
This PR adds int16 support for PACK and UNPACK ops.
bug=#2736