Skip to content

Add int16 support to PACK/UNPACK #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

andresovela
Copy link
Contributor

This PR adds int16 support for PACK and UNPACK ops.

bug=#2736

@andresovela
Copy link
Contributor Author

Not sure what's the deal with the failing CI

Copy link
Contributor

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Dec 10, 2024
@andresovela
Copy link
Contributor Author

Needs review

@ddavis-2015 ddavis-2015 removed the Stale label Dec 10, 2024
Copy link
Contributor

"This PR is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Jan 20, 2025
@andresovela
Copy link
Contributor Author

Needs review

@github-actions github-actions bot removed the Stale label Jan 21, 2025
Copy link
Member

@ddavis-2015 ddavis-2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresovela Thank you for your interest in TFLM (LRTM) and for submitting this PR!
Also, thank you for your persistence and perseverance.

This change looks good. Please make sure to merge with the latest main branch so there are no conflicts.

Also, another Google procedural requirement: All changed files should have the copyright year set the to current year (I know you submitted this last year). Only the current year should appear in the copyright.

@andresovela
Copy link
Contributor Author

Addressed concerns :)

Copy link
Member

@ddavis-2015 ddavis-2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suleshahid Everything looks good here.

@suleshahid
Copy link
Collaborator

Sorry for delayed review!

Copy link
Contributor

mergify bot commented Jun 2, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@suleshahid
Copy link
Collaborator

Ah, seems like Unpack int16 support was added in #3028 . Could you refactor?

@ddavis-2015
Copy link
Member

ddavis-2015 commented Jun 2, 2025

Ah, seems like Unpack int16 support was added in #3028 . Could you refactor?

@andresovela

Please remove the unpack.cc changes in your PR and keep in the PR the unpack_test.cc changes you made, as the test code was not submitted in PR #3028.

@andresovela
Copy link
Contributor Author

Hi @ddavis-2015, unfortunately priorities have changed at work and I no longer have time to work on this. Feel free to close the PR if it's already outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants