Re-disables enableScalarColumnContextMenus flag #6838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Apr 22, 2024
| @@ -111,7 +111,7 @@ export const FeatureFlagMetadataMap: FeatureFlagMetadataMapType<FeatureFlags> = | |||
| parseValue: parseBoolean, | |||
| }, | |||
| enableScalarColumnContextMenus: { | |||
| defaultValue: true, | |||
| defaultValue: false, | |||
There was a problem hiding this comment.
Can we instead enable ScalarColumnCustomization? Is there anything about it that forces it to be 1P-only?
There was a problem hiding this comment.
As mentioned in internal comms, I think the best plan is to dedupe the column customization functionality using the table affordances (add button, context menus). We can re-enable scalar table context menus in 3p after that's done.
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
## Motivation for features / changes In 3p, enabling standard (non-hparam column) hide is currently dangerous as there is currently no way to re-show them. Enabling for 3p will have to wait until we add an affordance other than the 1p-only column customizer. Affected users can clear localStorage for the page, or add the `enableScalarColumnCustomization=true` flag to enable the column customizer in the settings menu and re-add hidden columns. ## Technical description of changes Sets `enableScalarColumnContextMenus` default to `false`. (Reverts tensorflow#6817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
In 3p, enabling standard (non-hparam column) hide is currently dangerous as there is currently no way to re-show them. Enabling for 3p will have to wait until we add an affordance other than the 1p-only column customizer.
Affected users can clear localStorage for the page, or add the
enableScalarColumnCustomization=trueflag to enable the column customizer in the settings menu and re-add hidden columns.Technical description of changes
Sets
enableScalarColumnContextMenusdefault tofalse. (Reverts #6817)