Minor improvements for WebGL 2 and development. #317
Conversation
- Basic support for texSubImage3D. - Code support for Renderdoc, which is enabled via a define. - Fix for nodejs issue with detecting instances of buffer types. - Simple conversion for RGBA->RED pixel formats on texture upload.
| data instanceof Int32Array || | ||
| data instanceof Float32Array || | ||
| data instanceof Float64Array | ||
| return isInstanceOfType(data, 'Uint8Array') || |
There was a problem hiding this comment.
Could you briefly describe the issues in node with checking if it's a typed array with instanceof ? Something to do with tests / use in a vm module?
This looks fine, I'm more curious for myself – and perhaps there's a another, simpler yet still foolproof version.
| } | ||
|
|
||
| if ( | ||
| typeof pixels === 'object' && |
There was a problem hiding this comment.
Likely don't need this line, as it's checked for in the previous if statement
|
Overall, looks good. I think RenderDoc support is a good addition, especially since it's optional, and doesn't look too substantial to maintain. Would you mind adding a few lines to the README about RenderDoc support in headless-gl? Anything that might be useful to other devs looking to debug their program (unless there's nothing else to be done other than defining |
@dhritzkiv another small set of fixes/changes. If the RenderDoc stuff isn't welcome I can remove it, but it's useful to have locally.