-
Notifications
You must be signed in to change notification settings - Fork 30
refactor Event Schedule UI for new design + add personal schedule #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ce1979d
05887d2
b3636b7
6b6c57b
5717560
545575b
a6cd04b
020e7e5
d97a828
b578f71
cc504ba
32efd49
4620ee6
6c79ed9
a15ab35
c711c1d
9fce282
bd69d2a
5461bb1
b5f6424
23f9399
06620c6
97450fe
eedc4ab
4b5062d
3773b54
ad87fa8
6872d59
7bccbd0
f9a5a03
e8e72ac
e5721d0
ec6f178
90fcd9d
f746cd4
9f5cb16
23f86ae
28b4cc2
f92a651
a04cf8f
e926cc4
f347b80
1b5374a
2e96d5d
3f5f7e7
69f74f3
e380317
c43d2e6
78137c7
d55f4a8
a4704be
d58d806
84c633a
f6812cf
749fd0a
665b77b
0b6bf11
81778da
8b3d927
799902a
6d26a6f
03d7830
367c7e8
41bfff8
ca1b2af
1bc21ee
bbb1862
61c8d31
eaea734
a37241a
aa7ef18
8a48aea
959ba68
df146ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
@keyframes loadingspin { | ||
from { | ||
transform: rotate(0deg); | ||
} | ||
to { | ||
transform: rotate(360deg); | ||
} | ||
} | ||
|
||
$Loading__icon--size: 40px; | ||
$Loading__icon--margin-bottom: 1rem; | ||
$Loading__message--font-size: 0.9rem; | ||
$Loading__message--opacity: 0.6; | ||
|
||
.Loading { | ||
display: flex; | ||
flex-direction: column; | ||
width: 100%; | ||
text-align: center; | ||
|
||
&__icon { | ||
margin: 0 auto; | ||
width: $Loading__icon--size; | ||
height: $Loading__icon--size; | ||
margin-bottom: $Loading__icon--margin-bottom; | ||
animation: loadingspin 0.6s infinite linear; | ||
} | ||
|
||
&__message { | ||
font-size: $Loading__message--font-size; | ||
opacity: $Loading__message--opacity; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import React, { FC } from "react"; | ||
|
||
import LoadingIcon from "assets/icons/icon-loading.svg"; | ||
|
||
import "./Loading.scss"; | ||
|
||
export interface LoadingProps { | ||
message?: string; | ||
sunny-viktoryia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
export const Loading: FC<LoadingProps> = ({ message }) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Also, message should have a default value here. Probably There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. used and about default message. hmm. I wouldn't specify that. According to our styleguide there can be loading without text. So, in case the text is not needed we can use this component. what would you say? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I guess it depends what is likely to be our more common pattern. If we are going to write "Loading..." all over the place then it probably makes sense to default the text and then potentially add another optional prop for If we're more likely to use it without text, then not setting the default might be a better idea. cc // @mike-lvov Thoughts? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @0xdevalias I would say that not having the default
For other cases, I think we explicitly more specific message than |
||
return ( | ||
<div className="Loading"> | ||
<img className="Loading__icon" src={LoadingIcon} alt="loading" /> | ||
<span className="Loading__message">{message}</span> | ||
</div> | ||
); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { Loading } from "./Loading"; |
Uh oh!
There was an error while loading. Please reload this page.