Add test action #240
Add test action #240
Conversation
oguzhanunlu
force-pushed
the
test-action
branch
from
658490b to
14c48b9
Compare
|
Test action run successfully at https://github.com/snowplow-referer-parser/referer-parser/actions/runs/13855805169/job/38772241342 and added a commit with a clear message at 27b1bbc containing a test json with a datetimed name and a latest json. |
| git config --local user.name "github-actions[bot]" | ||
| git add resources/referers-$datetime.json resources/referers-latest.json | ||
| git commit -m "Add referers-$datetime.json" | ||
| git push |
There was a problem hiding this comment.
Does this push to a branch? And if yes, which branch?
Can you give an example of the URL that we then use for testing in the pipeline?
There was a problem hiding this comment.
this pushes to referer-json branch, pointed at
referer-parser/.github/workflows/test.yml
Line 17 in 14c48b9
an example url that I used in my test is
https://raw.githubusercontent.com/snowplow-referer-parser/referer-parser/refs/heads/referer-json/resources/referers-2025-03-14-113945.json
There was a problem hiding this comment.
OK understood. I like that.
Are you also going to delete the pull_request.yml github action, which I think you only added as a test/demo?
There was a problem hiding this comment.
And sorry one more thing... please could you add a code comment to this github action, to remind us what url to look for.
There was a problem hiding this comment.
Are you also going to delete the pull_request.yml github action, which I think you only added as a test/demo?
I wasn't planning to delete it as it makes sure any change to referers.yml in a PR is valid and the file can still be converted to json.
I'll add a comment to the github action.
There was a problem hiding this comment.
added another step to print the url e.g. https://github.com/snowplow-referer-parser/referer-parser/actions/runs/13857313589/job/38776935473#step:7:8 instead of a comment
This PR adds a test action to prepare a json with dated name under resources as well as updating the latest json.