Avoid focus ping pong between editors #2539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjarvstrand
force-pushed
the
avoid-focus-pingpong
branch
from
d27f201 to
2c93e94
Compare
EchoEllet
reviewed
Apr 15, 2025
Comment on lines
-1202
to
-1203
| } else { | ||
| widget.config.focusNode.requestFocus(); |
There was a problem hiding this comment.
Does this change the behavior for QuillRawEditor or cause an issue for users who use QuillRawEditor?
There was a problem hiding this comment.
Potentially.
It does not look to me as if focus would have to be requested from any of the places where QuillRawEditorState.requestKeyboard is called from within flutter-quill, but if anyone is calling that method from the outside and expecting the editor to receive focus, they will be disappointed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation,
requestKeyboardwill request focus if an editor is currently not focused.In certain situations, there can be a delay between getting focus and executing the callback. If the editor has lost focus in that time, it will try to steal it back. This is in itself not great, but what's worse is that if you have more than one editor and switch between them rapidly, you can end up in a state where one editor is constantly trying to steal the focus back from the other, ending up in a ping pong situation that freezes the entire app.
Description
This PR moves the call to
requestFocusout ofrequestKeyboard, so that it can instead be requested separately in the places where it's needed.Related Issues
Type of Change