Skip to content

Made keyboard inputs physical and add controller support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShawkMusic
Copy link

@ShawkMusic ShawkMusic commented Jul 6, 2023

Make keyboard inputs physical so they work on alternative keyboard layouts like Dvorak

Also added controller inputs (based off of BOTW's control scheme)

@ShawkMusic ShawkMusic changed the title Made keyboard inputs physical Made keyboard inputs physical and add controller support Jul 6, 2023
@ShawkMusic
Copy link
Author

This is my first merge request so sorry if I messed something up and please let me know if I did

@selgesel selgesel mentioned this pull request Jul 23, 2024
var dy := Input.get_action_strength("move_forward") - Input.get_action_strength("move_backwards")
# rotate the camera with controller
_cam_rot -= Input.get_vector("pan_left", "pan_right", "pan_up", "pan_down") * controller_sensitivity
_cam_rot.y = clamp(_cam_rot.y, min_pitch, max_pitch)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this interfere with the mouse controls? Can we still use the mouse without an issue even if a controller is plugged in or not?

@selgesel
Copy link
Owner

Hey, sorry for the super late reply, and thanks a lot for the contribution!

I left a small note regarding the use of mouse when a controller is plugged in or not, FYI.

Also, I've just added a Contribution Guide and changed the Input.get_action_strength() calls to Input.get_vector() like you have, which caused this branch to have conflicts. Sorry!

In addition to the conflicts and my note, can you please check out the contribution guide to fix the indentations to be spaces instead of tabs? Thanks!

@selgesel selgesel added the enhancement New feature or request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants